From patchwork Tue Oct 2 19:02:57 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 188622 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 656912C00A9 for ; Wed, 3 Oct 2012 05:03:13 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1349809393; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Received:From:To:Subject:Date:Message-ID: User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=0tTpLKxRKNEGmYxNAvRr4iIN664=; b=GAgfUry7bZY8UB+ w4f+WnlURfPdVgDlUVPqgbHjZaQLc52gsHDfjEq0fAPbRMXyYalMm/1Fz8O8JlF7 thq/OmGYQ7udTM/h4p70QGenKAyv9oN5Fwzn+BkNX1Gm0nsFsTaLjG4YjeIyS70q D5JPvwZWxVBjdYwURD1NJReZmMjw= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Received:From:To:Subject:Date:Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Rmkqw19myDPAkbysT8H3Gi9Zle0ZrsERstySEKOqa/kM1xg/xXUxCOeWPXqaIf runS9EC2cIfIZJ/3A/hEfaxaUXB76apuhAdZl2H6DTW+xLXVjvXF5v/zuz+SIeta QawKkyerPUNMJhO1J/fyrai+kF1IMGP8pNFiBgMG6Mh/k=; Received: (qmail 5456 invoked by alias); 2 Oct 2012 19:03:08 -0000 Received: (qmail 5387 invoked by uid 22791); 2 Oct 2012 19:03:07 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_SPAMHAUS_DROP, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, RP_MATCHES_RCVD, SPF_HELO_PASS, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Oct 2012 19:03:02 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q92J32nh027525 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 2 Oct 2012 15:03:02 -0400 Received: from freie (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q92J30jR012269 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 2 Oct 2012 15:03:01 -0400 Received: from livre.localdomain (livre-to-gw.oliva.athome.lsd.ic.unicamp.br [172.31.160.19]) by freie (8.14.5/8.14.5) with ESMTP id q92J2wDM007853 for ; Tue, 2 Oct 2012 16:02:58 -0300 Received: from livre.localdomain (aoliva@localhost.localdomain [127.0.0.1]) by livre.localdomain (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id q92J2ws4011172; Tue, 2 Oct 2012 16:02:58 -0300 Received: (from aoliva@localhost) by livre.localdomain (8.14.3/8.14.3/Submit) id q92J2vMb011169; Tue, 2 Oct 2012 16:02:57 -0300 From: Alexandre Oliva To: gcc-patches@gcc.gnu.org Subject: [PR53135] Use block4 form for large debug expressions Date: Tue, 02 Oct 2012 16:02:57 -0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This patch fixes a crash in dwarf2out because of a too-large debug expression. Jakub approved it for trunk and 4.7 branches in bugzilla. I'm installing it in the trunk momentarily, and later today on 4.7 after I give it a spin there. Regstrapped on x86_64-linux-gnu and i686-linux-gnu. I'm keeping the testcase open because we still have an underlying problem and other improvements to make. Use block4 form for large debug expressions. From: Alexandre Oliva for gcc/ChangeLog PR debug/53135 * dwarf2out.c (value_format): Use block4 for dw_val_class_loc when needed. --- gcc/dwarf2out.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c index c776f68..25f57c0 100644 --- a/gcc/dwarf2out.c +++ b/gcc/dwarf2out.c @@ -7491,6 +7491,8 @@ value_format (dw_attr_ref a) return DW_FORM_block1; case 2: return DW_FORM_block2; + case 4: + return DW_FORM_block4; default: gcc_unreachable (); }