Patchwork [38/41] block-migration: handle errors with the return codes correctly

login
register
mail settings
Submitter Juan Quintela
Date Oct. 2, 2012, 11:33 a.m.
Message ID <1349177616-5341-39-git-send-email-quintela@redhat.com>
Download mbox | patch
Permalink /patch/188474/
State New
Headers show

Comments

Juan Quintela - Oct. 2, 2012, 11:33 a.m.
Signed-off-by: Juan Quintela <quintela@redhat.com>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---
 block-migration.c | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)

Patch

diff --git a/block-migration.c b/block-migration.c
index 565628f..8b585d3 100644
--- a/block-migration.c
+++ b/block-migration.c
@@ -423,10 +423,9 @@  static int mig_save_device_dirty(QEMUFile *f, BlkMigDevState *bmds,

 error:
     DPRINTF("Error reading sector %" PRId64 "\n", sector);
-    qemu_file_set_error(f, ret);
     g_free(blk->buf);
     g_free(blk);
-    return 0;
+    return ret;
 }

 /* return value:
@@ -440,7 +439,7 @@  static int blk_mig_save_dirty_block(QEMUFile *f, int is_async)

     QSIMPLEQ_FOREACH(bmds, &block_mig_state.bmds_list, entry) {
         ret = mig_save_device_dirty(f, bmds, is_async);
-        if (ret == 0) {
+        if (ret <= 0) {
             break;
         }
     }
@@ -598,12 +597,17 @@  static int block_save_iterate(QEMUFile *f, void *opaque)
                 block_mig_state.bulk_completed = 1;
             }
         } else {
-            if (blk_mig_save_dirty_block(f, 1) != 0) {
+            ret = blk_mig_save_dirty_block(f, 1);
+            if (ret != 0) {
                 /* no more dirty blocks */
                 break;
             }
         }
     }
+    if (ret) {
+        blk_mig_cleanup();
+        return ret;
+    }

     ret = flush_blks(f);
     if (ret) {
@@ -635,18 +639,16 @@  static int block_save_complete(QEMUFile *f, void *opaque)
        all async read completed */
     assert(block_mig_state.submitted == 0);

-    while (blk_mig_save_dirty_block(f, 0) == 0) {
-        /* Do nothing */
-    }
-    blk_mig_cleanup();
-
-    /* report completion */
-    qemu_put_be64(f, (100 << BDRV_SECTOR_BITS) | BLK_MIG_FLAG_PROGRESS);
+    do {
+        ret = blk_mig_save_dirty_block(f, 0);
+    } while (ret == 0);

-    ret = qemu_file_get_error(f);
+    blk_mig_cleanup();
     if (ret) {
         return ret;
     }
+    /* report completion */
+    qemu_put_be64(f, (100 << BDRV_SECTOR_BITS) | BLK_MIG_FLAG_PROGRESS);

     DPRINTF("Block migration completed\n");