From patchwork Mon Oct 1 14:52:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 188312 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 017A12C00B3 for ; Tue, 2 Oct 2012 00:54:22 +1000 (EST) Received: from localhost ([::1]:50617 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIhO0-0007po-8o for incoming@patchwork.ozlabs.org; Mon, 01 Oct 2012 10:54:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIhMj-0004Mb-Fk for qemu-devel@nongnu.org; Mon, 01 Oct 2012 10:53:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIhMc-0002li-Ia for qemu-devel@nongnu.org; Mon, 01 Oct 2012 10:53:01 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:52777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIhMc-0002ld-8d for qemu-devel@nongnu.org; Mon, 01 Oct 2012 10:52:54 -0400 Received: by pbbrp2 with SMTP id rp2so7872317pbb.4 for ; Mon, 01 Oct 2012 07:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=NWxQYYvoWHPDRF2Bmdr4u4NMbHcGXanNa+5usBxJu54=; b=bB9cTpDEa3HeeiZPDi0EtPhwNbyl1vafCO+6sTJ3fT8YQIsngRFVzbHTG+axtPUqnW FWRzYeP3inCOakYArALCwJ4FvINCFjSDC1hF/bWuAMnNs27YUhJ7asgTiKsQADNsqqym zyxMlJxM8uC0JOPwaQfv5lF4BV5FuHdsv8FD0SVQMpbrbC3YmfvfDuouERFJlP7UjRh0 Rmw02riau0719sb9yqn5+dDDDz2jfPszM+tPYyczNEFaFzPQVlzvfOjwkXzMs7Ku3Kr3 GJF/55KUs4XURmWiV9mTnedXdj/ewlHmj2rnBAcorkWkzhdhgWXf5FgQgoXAay9CLB72 Xo+A== Received: by 10.68.235.38 with SMTP id uj6mr41706148pbc.3.1349103172617; Mon, 01 Oct 2012 07:52:52 -0700 (PDT) Received: from yakj.usersys.redhat.com (93-34-169-1.ip50.fastwebnet.it. [93.34.169.1]) by mx.google.com with ESMTPS id g1sm10494388paz.18.2012.10.01.07.52.49 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 01 Oct 2012 07:52:51 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 1 Oct 2012 16:52:20 +0200 Message-Id: <1349103144-6827-6-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.12 In-Reply-To: <1349103144-6827-1-git-send-email-pbonzini@redhat.com> References: <1349103144-6827-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.160.45 Cc: lcapitulino@redhat.com Subject: [Qemu-devel] [PATCH v2 5/9] qemu-sockets: return IPSocketAddress from inet_parse X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Prepare inet_parse so that it can be easily reused in socket_parse. socket_parse will be public and will help converting addresses accepted by HMP to SocketAddress structures accepted by the implementation of QMP commands. Signed-off-by: Paolo Bonzini Reviewed-by: Luiz Capitulino --- qemu-sockets.c | 119 +++++++++++++++++++++++++++++++++++++-------------------- 1 file modificato, 78 inserzioni(+), 41 rimozioni(-) diff --git a/qemu-sockets.c b/qemu-sockets.c index 1e69274..f67a113 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -511,54 +511,91 @@ err: } /* compatibility wrapper */ -static void inet_parse(QemuOpts *opts, const char *str, Error **errp) +static IPSocketAddress *inet_parse(const char *str, Error **errp) { + IPSocketAddress *addr; const char *optstr, *h; - char addr[64]; + char host[64]; char port[33]; + int to; int pos; + addr = g_new(IPSocketAddress, 1); + /* parse address */ if (str[0] == ':') { /* no host given */ - addr[0] = '\0'; + host[0] = '\0'; if (1 != sscanf(str,":%32[^,]%n",port,&pos)) { error_setg(errp, "error parsing port in address '%s'", str); - return; + goto fail; } } else if (str[0] == '[') { /* IPv6 addr */ - if (2 != sscanf(str,"[%64[^]]]:%32[^,]%n",addr,port,&pos)) { + if (2 != sscanf(str,"[%64[^]]]:%32[^,]%n",host,port,&pos)) { error_setg(errp, "error parsing IPv6 address '%s'", str); - return; + goto fail; } - qemu_opt_set(opts, "ipv6", "on"); + addr->ipv6 = addr->has_ipv6 = true; } else if (qemu_isdigit(str[0])) { /* IPv4 addr */ - if (2 != sscanf(str,"%64[0-9.]:%32[^,]%n",addr,port,&pos)) { + if (2 != sscanf(str,"%64[0-9.]:%32[^,]%n",host,port,&pos)) { error_setg(errp, "error parsing IPv4 address '%s'", str); - return; + goto fail; } - qemu_opt_set(opts, "ipv4", "on"); + addr->ipv4 = addr->has_ipv4 = true; } else { /* hostname */ - if (2 != sscanf(str,"%64[^:]:%32[^,]%n",addr,port,&pos)) { + if (2 != sscanf(str,"%64[^:]:%32[^,]%n",host,port,&pos)) { error_setg(errp, "error parsing address '%s'", str); - return; + goto fail; } } - qemu_opt_set(opts, "host", addr); - qemu_opt_set(opts, "port", port); + + addr->host = g_strdup(host); + addr->port = g_strdup(port); /* parse options */ optstr = str + pos; h = strstr(optstr, ",to="); - if (h) - qemu_opt_set(opts, "to", h+4); - if (strstr(optstr, ",ipv4")) - qemu_opt_set(opts, "ipv4", "on"); - if (strstr(optstr, ",ipv6")) - qemu_opt_set(opts, "ipv6", "on"); + if (h) { + if (1 != sscanf(str, "%d%n", &to, &pos) || + (str[pos] != '\0' && str[pos] != ',')) { + error_setg(errp, "error parsing to= argument"); + goto fail; + } + addr->has_to = true; + addr->to = to; + } + if (strstr(optstr, ",ipv4")) { + addr->ipv4 = addr->has_ipv4 = true; + } + if (strstr(optstr, ",ipv6")) { + addr->ipv6 = addr->has_ipv6 = true; + } + return addr; + +fail: + qapi_free_IPSocketAddress(addr); + return NULL; +} + +static void inet_addr_to_opts(QemuOpts *opts, IPSocketAddress *addr) +{ + bool ipv4 = addr->ipv4 || !addr->has_ipv4; + bool ipv6 = addr->ipv6 || !addr->has_ipv6; + + if (!ipv4 || !ipv6) { + qemu_opt_set_bool(opts, "ipv4", ipv4); + qemu_opt_set_bool(opts, "ipv6", ipv6); + } + if (addr->has_to) { + char to[20]; + snprintf(to, sizeof(to), "%d", addr->to); + qemu_opt_set(opts, "to", to); + } + qemu_opt_set(opts, "host", addr->host); + qemu_opt_set(opts, "port", addr->port); } int inet_listen(const char *str, char *ostr, int olen, @@ -567,11 +604,13 @@ int inet_listen(const char *str, char *ostr, int olen, QemuOpts *opts; char *optstr; int sock = -1; - Error *local_err = NULL; + IPSocketAddress *addr; - opts = qemu_opts_create(&dummy_opts, NULL, 0, NULL); - inet_parse(opts, str, &local_err); - if (local_err == NULL) { + addr = inet_parse(str, errp); + if (addr != NULL) { + opts = qemu_opts_create(&dummy_opts, NULL, 0, NULL); + inet_addr_to_opts(opts, addr); + qapi_free_IPSocketAddress(addr); sock = inet_listen_opts(opts, port_offset, errp); if (sock != -1 && ostr) { optstr = strchr(str, ','); @@ -587,10 +626,8 @@ int inet_listen(const char *str, char *ostr, int olen, optstr ? optstr : ""); } } - } else { - error_propagate(errp, local_err); + qemu_opts_del(opts); } - qemu_opts_del(opts); return sock; } @@ -606,16 +643,16 @@ int inet_connect(const char *str, Error **errp) { QemuOpts *opts; int sock = -1; - Error *local_err = NULL; + IPSocketAddress *addr; - opts = qemu_opts_create(&dummy_opts, NULL, 0, NULL); - inet_parse(opts, str, &local_err); - if (local_err == NULL) { + addr = inet_parse(str, errp); + if (addr != NULL) { + opts = qemu_opts_create(&dummy_opts, NULL, 0, NULL); + inet_addr_to_opts(opts, addr); + qapi_free_IPSocketAddress(addr); sock = inet_connect_opts(opts, errp, NULL, NULL); - } else { - error_propagate(errp, local_err); + qemu_opts_del(opts); } - qemu_opts_del(opts); return sock; } @@ -638,18 +675,18 @@ int inet_nonblocking_connect(const char *str, { QemuOpts *opts; int sock = -1; - Error *local_err = NULL; + IPSocketAddress *addr; g_assert(callback != NULL); - opts = qemu_opts_create(&dummy_opts, NULL, 0, NULL); - inet_parse(opts, str, &local_err); - if (local_err == NULL) { + addr = inet_parse(str, errp); + if (addr != NULL) { + opts = qemu_opts_create(&dummy_opts, NULL, 0, NULL); + inet_addr_to_opts(opts, addr); + qapi_free_IPSocketAddress(addr); sock = inet_connect_opts(opts, errp, callback, opaque); - } else { - error_propagate(errp, local_err); + qemu_opts_del(opts); } - qemu_opts_del(opts); return sock; }