Patchwork hw/arm_gic.c: Fix improper DPRINTF output.

login
register
mail settings
Submitter Evgeny Voevodin
Date Oct. 1, 2012, 12:11 p.m.
Message ID <1349093511-28443-1-git-send-email-e.voevodin@samsung.com>
Download mbox | patch
Permalink /patch/188279/
State New
Headers show

Comments

Evgeny Voevodin - Oct. 1, 2012, 12:11 p.m.
s->cpu_enabled is a massive, so s->cpu_enabled ? "En" : "Dis" returns
"En" always. We should use s->cpu_enabled[cpu] here.

Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>
---
 hw/arm_gic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Peter Maydell - Oct. 1, 2012, 12:30 p.m.
On 1 October 2012 13:11, Evgeny Voevodin <e.voevodin@samsung.com> wrote:
> s->cpu_enabled is a massive, so s->cpu_enabled ? "En" : "Dis" returns

"is an array"

> "En" always. We should use s->cpu_enabled[cpu] here.
>
> Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>

...but nice catch.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM

Patch

diff --git a/hw/arm_gic.c b/hw/arm_gic.c
index 55871fa..4024dae 100644
--- a/hw/arm_gic.c
+++ b/hw/arm_gic.c
@@ -566,7 +566,7 @@  static void gic_cpu_write(gic_state *s, int cpu, int offset, uint32_t value)
     switch (offset) {
     case 0x00: /* Control */
         s->cpu_enabled[cpu] = (value & 1);
-        DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled ? "En" : "Dis");
+        DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled[cpu] ? "En" : "Dis");
         break;
     case 0x04: /* Priority mask */
         s->priority_mask[cpu] = (value & 0xff);