From patchwork Mon Oct 1 10:03:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [13/19] UBUNTU: SAUCE: net: calxedaxgmac: drop some unnecessary register writes From: Ike Panhc X-Patchwork-Id: 188263 Message-Id: <1349085780-23546-1-git-send-email-ike.pan@canonical.com> To: kernel-team@lists.ubuntu.com Date: Mon, 1 Oct 2012 18:03:00 +0800 From: Rob Herring BugLink: http://launchpad.net/bugs/1059432 The interrupts have already been cleared, so we don't need to clear them again. Also, we could miss interrupts if they are cleared, but we don't process the packet. Signed-off-by: Rob Herring Signed-off-by: Ike Panhc --- drivers/net/ethernet/calxeda/xgmac.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c index 1cd13bf..3b87d0e 100644 --- a/drivers/net/ethernet/calxeda/xgmac.c +++ b/drivers/net/ethernet/calxeda/xgmac.c @@ -851,8 +851,6 @@ static void xgmac_tx_complete(struct xgmac_priv *priv) int i; void __iomem *ioaddr = priv->base; - writel(DMA_STATUS_TU | DMA_STATUS_NIS, ioaddr + XGMAC_DMA_STATUS); - while (dma_ring_cnt(priv->tx_head, priv->tx_tail, DMA_TX_RING_SZ)) { unsigned int entry = priv->tx_tail; struct sk_buff *skb = priv->tx_skbuff[entry]; @@ -1154,9 +1152,6 @@ static int xgmac_rx(struct xgmac_priv *priv, int limit) struct sk_buff *skb; int frame_len; - writel(DMA_STATUS_RI | DMA_STATUS_NIS, - priv->base + XGMAC_DMA_STATUS); - entry = priv->rx_tail; p = priv->dma_rx + entry; if (desc_get_owner(p))