Patchwork [13/19] UBUNTU: SAUCE: net: calxedaxgmac: drop some unnecessary register writes

login
register
mail settings
Submitter Ike Panhc
Date Oct. 1, 2012, 10:03 a.m.
Message ID <1349085780-23546-1-git-send-email-ike.pan@canonical.com>
Download mbox | patch
Permalink /patch/188263/
State New
Headers show

Comments

Ike Panhc - Oct. 1, 2012, 10:03 a.m.
From: Rob Herring <rob.herring@calxeda.com>

BugLink: http://launchpad.net/bugs/1059432

The interrupts have already been cleared, so we don't need to clear them
again. Also, we could miss interrupts if they are cleared, but we don't
process the packet.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: Ike Panhc <ike.pan@canonical.com>
---
 drivers/net/ethernet/calxeda/xgmac.c |    5 -----
 1 file changed, 5 deletions(-)

Patch

diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c
index 1cd13bf..3b87d0e 100644
--- a/drivers/net/ethernet/calxeda/xgmac.c
+++ b/drivers/net/ethernet/calxeda/xgmac.c
@@ -851,8 +851,6 @@  static void xgmac_tx_complete(struct xgmac_priv *priv)
 	int i;
 	void __iomem *ioaddr = priv->base;
 
-	writel(DMA_STATUS_TU | DMA_STATUS_NIS, ioaddr + XGMAC_DMA_STATUS);
-
 	while (dma_ring_cnt(priv->tx_head, priv->tx_tail, DMA_TX_RING_SZ)) {
 		unsigned int entry = priv->tx_tail;
 		struct sk_buff *skb = priv->tx_skbuff[entry];
@@ -1154,9 +1152,6 @@  static int xgmac_rx(struct xgmac_priv *priv, int limit)
 		struct sk_buff *skb;
 		int frame_len;
 
-		writel(DMA_STATUS_RI | DMA_STATUS_NIS,
-		       priv->base + XGMAC_DMA_STATUS);
-
 		entry = priv->rx_tail;
 		p = priv->dma_rx + entry;
 		if (desc_get_owner(p))