From patchwork Sun Sep 30 18:53:55 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 188189 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id F20B12C00D3 for ; Mon, 1 Oct 2012 04:53:51 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1349636033; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:From:To:Mail-Followup-To:Cc:Subject:References:Date: In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=vumi13C4IMCF27koWtIt b9CISTU=; b=vjw3K6TxD6DyRAnNbyXsCqzbDMx2N4SNMTO9HK2us3aljpYn0htx 7F3fSvZrRufJctGx1jzCqiXQihV7WcMwEQe9m9r6L7mKEFE+FmpO/t81lNgP0Oy3 XCeRhQi9dmtJsLzG4d8ogsuI87O85Nyz3KjEHP+Ux+gYc9l8Bywv7Xk= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:From:To:Mail-Followup-To:Cc:Subject:References:Date:In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=cDANrh3R3fi6RHLW9QG5kE6s4V0bSu3UQyMdQ2eqDFDfBh5k3/uo8aBp/1M66p dLSFY5E2q+CMYpJDpi2wCb6S5DAhMD2xc3jpqocIjXfd9s7uf7jVM+tziNZo+8kM maEOWIuqbr1dQcLTCgDa8VeM1fQYJOSThHx0zWJ6Buz7E=; Received: (qmail 29137 invoked by alias); 30 Sep 2012 18:53:47 -0000 Received: (qmail 29114 invoked by uid 22791); 30 Sep 2012 18:53:47 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-wi0-f179.google.com (HELO mail-wi0-f179.google.com) (209.85.212.179) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 30 Sep 2012 18:53:42 +0000 Received: by wibhq7 with SMTP id hq7so1370924wib.8 for ; Sun, 30 Sep 2012 11:53:41 -0700 (PDT) Received: by 10.180.95.97 with SMTP id dj1mr9715366wib.3.1349031221491; Sun, 30 Sep 2012 11:53:41 -0700 (PDT) Received: from localhost ([2.26.188.227]) by mx.google.com with ESMTPS id fb20sm13966961wid.1.2012.09.30.11.53.39 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 30 Sep 2012 11:53:40 -0700 (PDT) From: Richard Sandiford To: "Steve Ellcey " Mail-Followup-To: "Steve Ellcey " , , rdsandiford@googlemail.com Cc: Subject: Re: [patch, mips] Patch for new mips triplet - mips-mti-elf References: <3324456b-606c-494e-93ac-2479868f750d@EXCHHUB01.MIPS.com> Date: Sun, 30 Sep 2012 19:53:55 +0100 In-Reply-To: <3324456b-606c-494e-93ac-2479868f750d@EXCHHUB01.MIPS.com> (Steve Ellcey's message of "Thu, 13 Sep 2012 10:25:09 -0700") Message-ID: <87sj9zqr3w.fsf@talisman.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org "Steve Ellcey " writes: > diff --git a/gcc/testsuite/gcc.target/mips/pr37362.c b/gcc/testsuite/gcc.target/mips/pr37362.c > index a378366..da34b9d 100644 > --- a/gcc/testsuite/gcc.target/mips/pr37362.c > +++ b/gcc/testsuite/gcc.target/mips/pr37362.c > @@ -1,5 +1,5 @@ > /* mips*-sde-elf doesn't have 128-bit long doubles. */ > -/* { dg-do compile { target { ! mips*-sde-elf } } } */ > +/* { dg-do compile { target { ! mips*-sde-elf mips*-mti-elf } } } */ > /* { dg-options "-march=mips64r2 -mabi=n32" } */ > > typedef float TFtype __attribute__((mode(TF))); Sorry for only noticing now, but this produced: ERROR: gcc.target/mips/pr37362.c -O0 : syntax error in target selector "target ! mips*-sde-elf mips*-mti-elf" for " dg-do 2 compile { target { ! mips*-sde-elf mips*-mti-elf } } " ... We need another set of braces. Tested on mipsisa64-elf and applied. Richard gcc/testsuite/ * gcc.target/mips/pr37362.c: Fix target selector. Index: gcc/testsuite/gcc.target/mips/pr37362.c =================================================================== --- gcc/testsuite/gcc.target/mips/pr37362.c 2012-09-30 19:46:09.000000000 +0100 +++ gcc/testsuite/gcc.target/mips/pr37362.c 2012-09-30 19:49:05.146360070 +0100 @@ -1,5 +1,5 @@ /* mips*-sde-elf doesn't have 128-bit long doubles. */ -/* { dg-do compile { target { ! mips*-sde-elf mips*-mti-elf } } } */ +/* { dg-do compile { target { ! { mips*-sde-elf mips*-mti-elf } } } } */ /* { dg-options "-march=mips64r2 -mabi=n32" } */ typedef float TFtype __attribute__((mode(TF)));