Patchwork [mips] Patch for new mips triplet - mips-mti-elf

login
register
mail settings
Submitter Richard Sandiford
Date Sept. 30, 2012, 6:53 p.m.
Message ID <87sj9zqr3w.fsf@talisman.home>
Download mbox | patch
Permalink /patch/188189/
State New
Headers show

Comments

Richard Sandiford - Sept. 30, 2012, 6:53 p.m.
"Steve Ellcey " <sellcey@mips.com> writes:
> diff --git a/gcc/testsuite/gcc.target/mips/pr37362.c b/gcc/testsuite/gcc.target/mips/pr37362.c
> index a378366..da34b9d 100644
> --- a/gcc/testsuite/gcc.target/mips/pr37362.c
> +++ b/gcc/testsuite/gcc.target/mips/pr37362.c
> @@ -1,5 +1,5 @@
>  /* mips*-sde-elf doesn't have 128-bit long doubles.  */
> -/* { dg-do compile { target { ! mips*-sde-elf } } } */
> +/* { dg-do compile { target { ! mips*-sde-elf mips*-mti-elf } } } */
>  /* { dg-options "-march=mips64r2 -mabi=n32" } */
>  
>  typedef float TFtype __attribute__((mode(TF)));

Sorry for only noticing now, but this produced:

ERROR: gcc.target/mips/pr37362.c  -O0 : syntax error in target selector "target ! mips*-sde-elf mips*-mti-elf" for " dg-do 2 compile { target { ! mips*-sde-elf mips*-mti-elf } } "
...

We need another set of braces.  Tested on mipsisa64-elf and applied.

Richard


gcc/testsuite/
	* gcc.target/mips/pr37362.c: Fix target selector.
Steve Ellcey - Oct. 1, 2012, 4:03 p.m.
On Sun, 2012-09-30 at 19:53 +0100, Richard Sandiford wrote:

> Sorry for only noticing now, but this produced:
> 
> ERROR: gcc.target/mips/pr37362.c  -O0 : syntax error in target selector "target ! mips*-sde-elf mips*-mti-elf" for " dg-do 2 compile { target { ! mips*-sde-elf mips*-mti-elf } } "
> ...
> 
> We need another set of braces.  Tested on mipsisa64-elf and applied.
> 
> Richard

Thanks for fixing this, I am not sure why I didn't notice it in my
testing.

Steve Ellcey
sellcey@mips.com

Patch

Index: gcc/testsuite/gcc.target/mips/pr37362.c
===================================================================
--- gcc/testsuite/gcc.target/mips/pr37362.c	2012-09-30 19:46:09.000000000 +0100
+++ gcc/testsuite/gcc.target/mips/pr37362.c	2012-09-30 19:49:05.146360070 +0100
@@ -1,5 +1,5 @@ 
 /* mips*-sde-elf doesn't have 128-bit long doubles.  */
-/* { dg-do compile { target { ! mips*-sde-elf mips*-mti-elf } } } */
+/* { dg-do compile { target { ! { mips*-sde-elf mips*-mti-elf } } } } */
 /* { dg-options "-march=mips64r2 -mabi=n32" } */
 
 typedef float TFtype __attribute__((mode(TF)));