From patchwork Sat Sep 29 15:53:49 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Increasing XT_EXTENSION_MAXNAMELEN to 32 Date: Sat, 29 Sep 2012 05:53:49 -0000 From: Amerigo Wang X-Patchwork-Id: 188034 Message-Id: <1348934029.10238.15.camel@cr0> To: netfilter-devel@vger.kernel.org Cc: Pablo Neira Ayuso , Patrick McHardy Hi, netfilter experts, A customer wants to increase XT_EXTENSION_MAXNAMELEN to at least 31 (1 for '\0'), so I just increase it to 32. Do you have any comments or objections for the following patch? The vmlinux size increases by 768 bytes with my allyesconfig: % size vmlinux text data bss dec hex filename 15158877 3942208 11812864 30913949 1d7b59d vmlinux % size vmlinux.AFTER text data bss dec hex filename 15158877 3942976 11812864 30914717 1d7b89d vmlinux.AFTER I know probably the user-space part needs to update too, here is just the kernel part patch for you to review. And I only did compile test. Thanks! --- -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/linux/netfilter/x_tables.h b/include/linux/netfilter/x_tables.h index 8d674a7..24b4dd4 100644 --- a/include/linux/netfilter/x_tables.h +++ b/include/linux/netfilter/x_tables.h @@ -4,7 +4,7 @@ #include #define XT_FUNCTION_MAXNAMELEN 30 -#define XT_EXTENSION_MAXNAMELEN 29 +#define XT_EXTENSION_MAXNAMELEN 32 #define XT_TABLE_MAXNAMELEN 32 struct xt_entry_match {