From patchwork Sat Sep 29 15:53:49 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amerigo Wang X-Patchwork-Id: 188034 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 097582C00BA for ; Sun, 30 Sep 2012 01:54:09 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756497Ab2I2PyG (ORCPT ); Sat, 29 Sep 2012 11:54:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20046 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756172Ab2I2PyF (ORCPT ); Sat, 29 Sep 2012 11:54:05 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8TFrsf2006365 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 29 Sep 2012 11:53:55 -0400 Received: from [10.64.244.154] (vpn-244-154.nrt.redhat.com [10.64.244.154]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q8TFroft022483 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 29 Sep 2012 11:53:52 -0400 Message-ID: <1348934029.10238.15.camel@cr0> Subject: Increasing XT_EXTENSION_MAXNAMELEN to 32 From: Cong Wang To: netfilter-devel@vger.kernel.org Cc: Pablo Neira Ayuso , Patrick McHardy Date: Sat, 29 Sep 2012 23:53:49 +0800 Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hi, netfilter experts, A customer wants to increase XT_EXTENSION_MAXNAMELEN to at least 31 (1 for '\0'), so I just increase it to 32. Do you have any comments or objections for the following patch? The vmlinux size increases by 768 bytes with my allyesconfig: % size vmlinux text data bss dec hex filename 15158877 3942208 11812864 30913949 1d7b59d vmlinux % size vmlinux.AFTER text data bss dec hex filename 15158877 3942976 11812864 30914717 1d7b89d vmlinux.AFTER I know probably the user-space part needs to update too, here is just the kernel part patch for you to review. And I only did compile test. Thanks! --- -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/linux/netfilter/x_tables.h b/include/linux/netfilter/x_tables.h index 8d674a7..24b4dd4 100644 --- a/include/linux/netfilter/x_tables.h +++ b/include/linux/netfilter/x_tables.h @@ -4,7 +4,7 @@ #include #define XT_FUNCTION_MAXNAMELEN 30 -#define XT_EXTENSION_MAXNAMELEN 29 +#define XT_EXTENSION_MAXNAMELEN 32 #define XT_TABLE_MAXNAMELEN 32 struct xt_entry_match {