From patchwork Fri Sep 28 17:42:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: libgo patch committed: runtime.Caller should succeed without debug info Date: Fri, 28 Sep 2012 07:42:58 -0000 From: Ian Taylor X-Patchwork-Id: 187846 Message-Id: To: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Further testing uncovered a small bug in the change to use the libbacktrace library. The runtime.Caller function should succeed if we get the PC, even if we don't have any debug info. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r dff305030965 libgo/runtime/go-caller.c --- a/libgo/runtime/go-caller.c Fri Sep 28 07:26:19 2012 -0700 +++ b/libgo/runtime/go-caller.c Fri Sep 28 08:49:33 2012 -0700 @@ -172,7 +172,8 @@ if (n < 1) return ret; ret.pc = pc; - ret.ok = __go_file_line (pc, &fn, &ret.file, &ret.line); + __go_file_line (pc, &fn, &ret.file, &ret.line); + ret.ok = 1; return ret; }