Patchwork libgo patch committed: runtime.Caller should succeed without debug info

login
register
mail settings
Submitter Ian Taylor
Date Sept. 28, 2012, 5:42 p.m.
Message ID <mcrzk4adowt.fsf@google.com>
Download mbox | patch
Permalink /patch/187846/
State New
Headers show

Comments

Ian Taylor - Sept. 28, 2012, 5:42 p.m.
Further testing uncovered a small bug in the change to use the
libbacktrace library.  The runtime.Caller function should succeed if we
get the PC, even if we don't have any debug info.  Bootstrapped and ran
Go testsuite on x86_64-unknown-linux-gnu.  Committed to mainline.

Ian

Patch

diff -r dff305030965 libgo/runtime/go-caller.c
--- a/libgo/runtime/go-caller.c	Fri Sep 28 07:26:19 2012 -0700
+++ b/libgo/runtime/go-caller.c	Fri Sep 28 08:49:33 2012 -0700
@@ -172,7 +172,8 @@ 
   if (n < 1)
     return ret;
   ret.pc = pc;
-  ret.ok = __go_file_line (pc, &fn, &ret.file, &ret.line);
+  __go_file_line (pc, &fn, &ret.file, &ret.line);
+  ret.ok = 1;
   return ret;
 }