libgo patch committed: runtime.Caller should succeed without debug info

Submitted by Ian Taylor on Sept. 28, 2012, 5:42 p.m.

Details

Message ID mcrzk4adowt.fsf@google.com
State New
Headers show

Commit Message

Ian Taylor Sept. 28, 2012, 5:42 p.m.
Further testing uncovered a small bug in the change to use the
libbacktrace library.  The runtime.Caller function should succeed if we
get the PC, even if we don't have any debug info.  Bootstrapped and ran
Go testsuite on x86_64-unknown-linux-gnu.  Committed to mainline.

Ian

Patch hide | download patch | download mbox

diff -r dff305030965 libgo/runtime/go-caller.c
--- a/libgo/runtime/go-caller.c	Fri Sep 28 07:26:19 2012 -0700
+++ b/libgo/runtime/go-caller.c	Fri Sep 28 08:49:33 2012 -0700
@@ -172,7 +172,8 @@ 
   if (n < 1)
     return ret;
   ret.pc = pc;
-  ret.ok = __go_file_line (pc, &fn, &ret.file, &ret.line);
+  __go_file_line (pc, &fn, &ret.file, &ret.line);
+  ret.ok = 1;
   return ret;
 }