Patchwork ata: Fix build error in sata_highbank

login
register
mail settings
Submitter Mark Langsdorf
Date Sept. 28, 2012, 5:23 p.m.
Message ID <1348853017-9205-1-git-send-email-mark.langsdorf@calxeda.com>
Download mbox | patch
Permalink /patch/187845/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Mark Langsdorf - Sept. 28, 2012, 5:23 p.m.
From: Mark Langsdorf <Mark Langsdorf>

Allow sata_highbank to build even if no other users of libahci.o are built.

Signed-off-by: Mark Langsdorf <mark.langsdorf@calxeda.com>
---
 drivers/ata/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Jan Ceuleers - Sept. 28, 2012, 5:30 p.m.
On 09/28/2012 07:23 PM, Mark Langsdorf wrote:
> From: Mark Langsdorf <Mark Langsdorf>

Mark,

This From: line is malformed: the bit between the angle brackets should
contain an email address.

HTH, Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sedat Dilek - Sept. 28, 2012, 5:37 p.m.
On Fri, Sep 28, 2012 at 7:30 PM, Jan Ceuleers <jan.ceuleers@computer.org> wrote:
> On 09/28/2012 07:23 PM, Mark Langsdorf wrote:
>> From: Mark Langsdorf <Mark Langsdorf>
>
> Mark,
>
> This From: line is malformed: the bit between the angle brackets should
> contain an email address.
>

Randy sent a patch to linux-next ML and pinged again on this (see [1]).
I see no Reported-by... no S-o-b :-(.

- Sedat -

[1] http://marc.info/?t=134807860300006&r=1&w=2

> HTH, Jan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Langsdorf - Sept. 28, 2012, 5:56 p.m.
On 09/28/2012 12:37 PM, Sedat Dilek wrote:
> On Fri, Sep 28, 2012 at 7:30 PM, Jan Ceuleers <jan.ceuleers@computer.org> wrote:
>> On 09/28/2012 07:23 PM, Mark Langsdorf wrote:
>>> From: Mark Langsdorf <Mark Langsdorf>
>>
>> Mark,
>>
>> This From: line is malformed: the bit between the angle brackets should
>> contain an email address.
>>
> 
> Randy sent a patch to linux-next ML and pinged again on this (see [1]).
> I see no Reported-by... no S-o-b :-(.
> 
> - Sedat -
> 
> [1] http://marc.info/?t=134807860300006&r=1&w=2

I submitted patch immediately after he reported it and was told that
Jeff Garzik would push it up:

http://patchwork.kernel.org/patch/1460971

I'm really not sure why this isn't in linux-next already.

--Mark Langsdorf
Calxeda, Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index 8b384f1..9329daf 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -9,7 +9,7 @@  obj-$(CONFIG_SATA_FSL)		+= sata_fsl.o
 obj-$(CONFIG_SATA_INIC162X)	+= sata_inic162x.o
 obj-$(CONFIG_SATA_SIL24)	+= sata_sil24.o
 obj-$(CONFIG_SATA_DWC)		+= sata_dwc_460ex.o
-obj-$(CONFIG_SATA_HIGHBANK)	+= sata_highbank.o
+obj-$(CONFIG_SATA_HIGHBANK)	+= sata_highbank.o libahci.o
 
 # SFF w/ custom DMA
 obj-$(CONFIG_PDC_ADMA)		+= pdc_adma.o