[18/19] qemu-iotests: map underscore to dash in QMP argument names

Submitted by Paolo Bonzini on Sept. 28, 2012, 3:23 p.m.


Message ID 1348845782-15073-19-git-send-email-pbonzini@redhat.com
State New
Headers show

Commit Message

Paolo Bonzini Sept. 28, 2012, 3:23 p.m.
iotests.py provides a convenience function that uses Python keyword
arguments to represent QMP command arguments.  However, almost all
QMP commands use dashes for argument names (the sole exception is
block_set_io_throttle), and dashes are not allowed in a keyword
argument name.  Hence provide automatic conversion of underscores
to dashes.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
 tests/qemu-iotests/iotests.py | 8 +++++++-
 1 file modificato, 7 inserzioni(+). 1 rimozione(-)

Patch hide | download patch | download mbox

diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index e05b1d6..a94ea75 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -19,6 +19,7 @@ 
 import os
 import re
 import subprocess
+import string
 import unittest
 import sys; sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'QMP'))
 import qmp
@@ -96,9 +97,14 @@  class VM(object):
             self._popen = None
+    underscore_to_dash = string.maketrans('_', '-')
     def qmp(self, cmd, **args):
         '''Invoke a QMP command and return the result dict'''
-        return self._qmp.cmd(cmd, args=args)
+        qmp_args = dict()
+        for k in args.keys():
+            qmp_args[k.translate(self.underscore_to_dash)] = args[k]
+        return self._qmp.cmd(cmd, args=qmp_args)
     def get_qmp_events(self, wait=False):
         '''Poll for queued QMP events and return a list of dicts'''