Patchwork Support for package liblog4c-localtime

login
register
mail settings
Submitter Alexander Varnin
Date Sept. 28, 2012, 4:20 p.m.
Message ID <5065CE40.70500@mail.ru>
Download mbox | patch
Permalink /patch/187830/
State Superseded
Headers show

Comments

Alexander Varnin - Sept. 28, 2012, 4:20 p.m.
Sorry, forget to include patch file.

28.09.2012 20:18, Alexander Varnin пишет:
> Hello.
> I've added package to buildroot to support liblog4c logging library 
> (the version with localtime patch).
> Please, include it in the main tree.
> Alexander.
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni - Sept. 28, 2012, 5:27 p.m.
Dear Alexander Varnin,

On Fri, 28 Sep 2012 20:20:16 +0400, Alexander Varnin wrote:

> Sorry, forget to include patch file.

Please don't send patches as attached files, because we can't easily
comment on them. If you want to send patches properly, use the 'git
send-email' tool.

A few comments:

 * You're specifying a LIBLOG4C_SOURCE variable, but this variable is
   ignored because your LIBLOG4C_SITE starts with git://. You have to
   decide whether you want a tarball download (so LIBLOG4C_SOURCE
   should be a tarball name, and LIBLOG4C_SITE should be a http or ftp
   url) or if you want a Git download (so LIBLOG4C_SOURCE should not be
   set, and LIBLOG4C_SITE should point to a Git repository)

 * LIBLOG4C_INSTALL_STAGING should be set to YES. Your package is a
   library, and you are defining the <foo>_INSTALL_STAGING_CMDS
   variable.

 * Looking at https://github.com/rcmadruga/log4c-localtime, this
   package seems to use the autotools, so you should be using the
   autotools-package infrastructure, and most likely you don't need to
   define any of the LIBLOG4C_BUILD_CMDS, LIBLOG4C_INSTALL_STAGING_CMDS
   and LIBLOG4C_INSTALL_TARGET_CMDS variables.

 * There should not be a commented line in your
   <foo>_INSTALL_TARGET_CMDS variable. Ditto for <foo>_DEVICES and
   <foo>_PERMISSIONS.

Best regards,

Thomas
Thomas Petazzoni - Sept. 29, 2012, 8:39 a.m.
Alexander,

On Sat, 29 Sep 2012 12:14:45 +0400, Alexander Varnin wrote:

> Thank you. I'll fix what you say, and send updated patch on monday.

Ok, great. Please keep the list in Cc when replying to me about
Buildroot things.

Best regards,

Thomas

Patch

From d51d0a5dcea970b7797259fbe78f5d1776fe528e Mon Sep 17 00:00:00 2001
From: Alexander Varnin <fenixk19@mail.ru>
Date: Fri, 28 Sep 2012 13:37:55 +0400
Subject: [PATCH] New package liblog4c-localtime

---
 package/Config.in                                |    1 +
 package/liblog4c-localtime/Config.in             |    9 +++++
 package/liblog4c-localtime/liblog4c-localtime.mk |   35 ++++++++++++++++++++++
 3 files changed, 45 insertions(+), 0 deletions(-)
 create mode 100644 package/liblog4c-localtime/Config.in
 create mode 100644 package/liblog4c-localtime/liblog4c-localtime.mk

diff --git a/package/Config.in b/package/Config.in
index 8a7c9c4..25752e5 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -387,6 +387,7 @@  source "package/lttng-libust/Config.in"
 source "package/orc/Config.in"
 source "package/poco/Config.in"
 source "package/startup-notification/Config.in"
+source "package/liblog4c-localtime/Config.in"
 endmenu
 
 menu "Text and terminal handling"
diff --git a/package/liblog4c-localtime/Config.in b/package/liblog4c-localtime/Config.in
new file mode 100644
index 0000000..db1a76f
--- /dev/null
+++ b/package/liblog4c-localtime/Config.in
@@ -0,0 +1,9 @@ 
+config BR2_PACKAGE_LIBLOG4C
+	bool "liblog4c"
+	help
+	  Log4c is a library of C for flexible logging to files, syslog 
+	  and other destinations.
+	  This version is with localtime patch, to make lib show times in
+	  local timezone.
+
+	  https://github.com/rcmadruga/log4c-localtime
diff --git a/package/liblog4c-localtime/liblog4c-localtime.mk b/package/liblog4c-localtime/liblog4c-localtime.mk
new file mode 100644
index 0000000..c80c3e7
--- /dev/null
+++ b/package/liblog4c-localtime/liblog4c-localtime.mk
@@ -0,0 +1,35 @@ 
+ #############################################################
+ #
+ # liblog4c
+ #
+ #############################################################
+ LIBLOG4C_VERSION = 1.2.1
+ LIBLOG4C_SOURCE = libfoo-$(LIBLOG4C_VERSION).tar.gz
+ LIBLOG4C_SITE = git://github.com/rcmadruga/log4c-localtime.git
+ LIBLOG4C_INSTALL_STAGING = NO
+ LIBLOG4C_DEPENDENCIES = 
+
+ define LIBLOG4C_BUILD_CMDS
+     $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
+ endef
+
+ define LIBLOG4C_INSTALL_STAGING_CMDS
+     $(INSTALL) -D -m 0755 $(@D)/liblog4c.a $(STAGING_DIR)/usr/lib/liblog4c.a
+     $(INSTALL) -D -m 0644 $(@D)/liblog4c.h $(STAGING_DIR)/usr/include/liblog4c.h
+     $(INSTALL) -D -m 0755 $(@D)/liblog4c.so* $(STAGING_DIR)/usr/lib
+ endef
+
+ define LIBLOG4C_INSTALL_TARGET_CMDS
+     $(INSTALL) -D -m 0755 $(@D)/liblog4c.so* $(TARGET_DIR)/usr/lib
+     #$(INSTALL) -d -m 0755 $(TARGET_DIR)/etc/foo.d
+ endef
+
+ define LIBLOG4C_DEVICES
+     #/dev/foo  c  666  0  0  42  0  -  -  -
+ endef
+
+ define LIBLOG4C_PERMISSIONS
+    # /bin/foo  f  4755  0  0  -  -  -  -  -
+ endef
+
+ $(eval $(generic-package))
-- 
1.7.2.5