Patchwork tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code

login
register
mail settings
Submitter Peter Maydell
Date Sept. 28, 2012, 3:05 p.m.
Message ID <1348844740-20038-1-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/187797/
State New
Headers show

Comments

Peter Maydell - Sept. 28, 2012, 3:05 p.m.
Use the recently introduced tcg_out_mov_reg() function rather than
the equivalent inline code.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
This is a minor follow-on cleanup patch after commit 9716ef3b1.

 tcg/arm/tcg-target.c |   15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)
Peter Maydell - Sept. 28, 2012, 3:17 p.m.
On 28 September 2012 16:05, Peter Maydell <peter.maydell@linaro.org> wrote:
> Use the recently introduced tcg_out_mov_reg() function rather than
> the equivalent inline code.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Whoops, used git send-email on wrong file; please ignore this email.
Correct patch should arrive shortly.

-- PMM

Patch

diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
index 2bad0a2..5e8dbdd 100644
--- a/tcg/arm/tcg-target.c
+++ b/tcg/arm/tcg-target.c
@@ -1197,20 +1197,11 @@  static inline void tcg_out_qemu_ld(TCGContext *s, const TCGArg *args, int opc)
     case 1:
     case 2:
     default:
-        if (data_reg != TCG_REG_R0) {
-            tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
-                            data_reg, 0, TCG_REG_R0, SHIFT_IMM_LSL(0));
-        }
+        tcg_out_mov_reg(s, COND_AL, data_reg, TCG_REG_R0);
         break;
     case 3:
-        if (data_reg != TCG_REG_R0) {
-            tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
-                            data_reg, 0, TCG_REG_R0, SHIFT_IMM_LSL(0));
-        }
-        if (data_reg2 != TCG_REG_R1) {
-            tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
-                            data_reg2, 0, TCG_REG_R1, SHIFT_IMM_LSL(0));
-        }
+        tcg_out_mov_reg(s, COND_AL, data_reg, TCG_REG_R0);
+        tcg_out_mov_reg(s, COND_AL, data_reg2, TCG_REG_R1);
         break;
     }