From patchwork Fri Sep 28 12:13:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Precise/Quantal] HID: ntrig: change default value of logical/physical width/height to 1 From: Jesse Sung X-Patchwork-Id: 187774 Message-Id: <1348834385-1082-1-git-send-email-jesse.sung@canonical.com> To: kernel-team@lists.ubuntu.com Date: Fri, 28 Sep 2012 20:13:05 +0800 From: Wen-chien Jesse Sung BugLink: https://launchpad.net/bugs/1044248 Since something will be divided by these variables in show_min_width()/show_min_height() and show_activate_width()/ show_activate_height(), a divided error would be triggered if they are zero. Signed-off-by: Wen-chien Jesse Sung Acked-by: Rafi Rubin Signed-off-by: Jiri Kosina (cherry picked from commit 4cc9834518efed3b69d3a8ff3bd162e089f68d34 in hid git tree) Signed-off-by: Wen-chien Jesse Sung --- drivers/hid/hid-ntrig.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c index 9fae2eb..86a969f 100644 --- a/drivers/hid/hid-ntrig.c +++ b/drivers/hid/hid-ntrig.c @@ -882,10 +882,10 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id) nd->activate_slack = activate_slack; nd->act_state = activate_slack; nd->deactivate_slack = -deactivate_slack; - nd->sensor_logical_width = 0; - nd->sensor_logical_height = 0; - nd->sensor_physical_width = 0; - nd->sensor_physical_height = 0; + nd->sensor_logical_width = 1; + nd->sensor_logical_height = 1; + nd->sensor_physical_width = 1; + nd->sensor_physical_height = 1; hid_set_drvdata(hdev, nd);