Patchwork [v3] external-toolchain: BR2_TOOLCHAIN_EXTERNAL_GLIBC includes eglibc

login
register
mail settings
Submitter Baruch Siach
Date Sept. 27, 2012, 7:10 p.m.
Message ID <1348773014-19000-1-git-send-email-baruch@tkos.co.il>
Download mbox | patch
Permalink /patch/187450/
State Superseded
Headers show

Comments

Baruch Siach - Sept. 27, 2012, 7:10 p.m.
Yann E. MORIN says:

    "Although eglibc can be configured to include/exclude parts of the
    features, it seems to not be in wide use, if at all."

Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
v3: rephrase the help text to make it clear that the eglibc build is given,
    address the comment of Thomas Petazzoni.

v2: mention in the help text that eglibc may lack some features as suggested
    by Yann E. MORIN.

 toolchain/toolchain-external/Config.in |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Yann E. MORIN - Sept. 27, 2012, 7:20 p.m.
Baruch, All,

On Thursday 27 September 2012 21:10:14 Baruch Siach wrote:
> Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> v3: rephrase the help text to make it clear that the eglibc build is given,
>     address the comment of Thomas Petazzoni.
[--SNIP--]
>  config BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC
> -	bool "glibc"
> +	bool "glibc/eglibc"
>  	select BR2_TOOLCHAIN_EXTERNAL_GLIBC
> +	help
> +	  Note: eglibc is a variant of glibc that (among other things) can be
> +	  configured to exclude parts of its features. This capability is 
> +	  currently not supported.

Yes, that is very good!

Regards,
Yann E. MORIN.
Baruch Siach - Sept. 27, 2012, 7:30 p.m.
Hi Yann,

On Thu, Sep 27, 2012 at 09:20:01PM +0200, Yann E. MORIN wrote:
> On Thursday 27 September 2012 21:10:14 Baruch Siach wrote:
> > Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> > v3: rephrase the help text to make it clear that the eglibc build is given,
> >     address the comment of Thomas Petazzoni.
> [--SNIP--]
> >  config BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC
> > -	bool "glibc"
> > +	bool "glibc/eglibc"
> >  	select BR2_TOOLCHAIN_EXTERNAL_GLIBC
> > +	help
> > +	  Note: eglibc is a variant of glibc that (among other things) can be
> > +	  configured to exclude parts of its features. This capability is 
> > +	  currently not supported.
> 
> Yes, that is very good!

Sorry, this is actually v2. I've just sent v4 with the corrected text 
addressing (I hope) Thomas' comment.

baruch

Patch

diff --git a/toolchain/toolchain-external/Config.in b/toolchain/toolchain-external/Config.in
index f86ed74..f7a84b2 100644
--- a/toolchain/toolchain-external/Config.in
+++ b/toolchain/toolchain-external/Config.in
@@ -664,8 +664,12 @@  config BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC
 	select BR2_TOOLCHAIN_HAS_SHADOW_PASSWORDS
 
 config BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC
-	bool "glibc"
+	bool "glibc/eglibc"
 	select BR2_TOOLCHAIN_EXTERNAL_GLIBC
+	help
+	  Note: eglibc is a variant of glibc that (among other things) can be
+	  configured to exclude parts of its features. This capability is 
+	  currently not supported.
 
 endchoice