Patchwork mm: compaction: cache if a pageblock was scanned and no pages were isolated -fix2

login
register
mail settings
Submitter Mel Gorman
Date Sept. 27, 2012, 12:06 p.m.
Message ID <20120927120621.GB3429@suse.de>
Download mbox | patch
Permalink /patch/187339/
State New
Headers show

Comments

Mel Gorman - Sept. 27, 2012, 12:06 p.m.
The clearing of PG_migrate_skip potentially takes a long time if the
zone is massive. Be safe and check if it needs to reschedule.

This is a fix for
mm-compaction-cache-if-a-pageblock-was-scanned-and-no-pages-were-isolated.patch

Signed-off-by: Mel Gorman <mgorman@suse.de>
---
 mm/compaction.c |    3 +++
 1 file changed, 3 insertions(+)

Patch

diff --git a/mm/compaction.c b/mm/compaction.c
index fb07abb..722d10f 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -85,6 +85,9 @@  static void reset_isolation_suitable(struct zone *zone)
 	/* Walk the zone and mark every pageblock as suitable for isolation */
 	for (pfn = start_pfn; pfn < end_pfn; pfn += pageblock_nr_pages) {
 		struct page *page;
+
+		cond_resched();
+
 		if (!pfn_valid(pfn))
 			continue;