Patchwork cpu: Add missing 'static' attribute to qemu_global_mutex

login
register
mail settings
Submitter Stefan Weil
Date Sept. 27, 2012, 5:41 a.m.
Message ID <1348724502-22542-1-git-send-email-sw@weilnetz.de>
Download mbox | patch
Permalink /patch/187279/
State Accepted
Headers show

Comments

Stefan Weil - Sept. 27, 2012, 5:41 a.m.
Contrary to its name, 'qemu_global_mutex' is only used locally
in cpus.c.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 cpus.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Stefan Hajnoczi - Oct. 5, 2012, 12:11 p.m.
On Thu, Sep 27, 2012 at 07:41:42AM +0200, Stefan Weil wrote:
> Contrary to its name, 'qemu_global_mutex' is only used locally
> in cpus.c.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  cpus.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/cpus.c b/cpus.c
index 33da623..348b414 100644
--- a/cpus.c
+++ b/cpus.c
@@ -613,7 +613,7 @@  static void qemu_tcg_init_cpu_signals(void)
 }
 #endif /* _WIN32 */
 
-QemuMutex qemu_global_mutex;
+static QemuMutex qemu_global_mutex;
 static QemuCond qemu_io_proceeded_cond;
 static bool iothread_requesting_mutex;