Message ID | 1348701327-12226-1-git-send-email-computersforpeace@gmail.com |
---|---|
State | Accepted |
Commit | 30fad64325ba368ffe1f92bd37f4b96c1fa4da83 |
Headers | show |
On Wed, 2012-09-26 at 16:15 -0700, Brian Norris wrote: > Since the introduction of nand_create_default_bbt_descr() (now known as > nand_create_badblock_pattern()) in > > commit 58373ff0afff4cc8ac40608872995f4d87eb72ec > > nand_chip.badblock_pattern will be dynamically calculated to the same > 1-byte-length pattern that is required by fsl_elbc_nand. This custom > badblock_pattern is no longer needed, then, and its removal may help > facilitate further nand_bbt.c/nand_base.c cleanup in the future (one > down, many to go?) > > Anyway, with nand_bbt.c fixed, this effectively reverts: > > commit 452db2724351ff3d9416a183a7955e00ab4e6ab4 > [MTD] [NAND] fsl_elbc_nand: fix OOB workability for large page NAND chips > > Signed-off-by: Brian Norris <computersforpeace@gmail.com> > Cc: Scott Wood <scottwood@freescale.com> > --- > > Not even compile-tested... Compile-tested and pushed to l2-mtd.git, thanks!
diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c index cc1480a..4c4d3e5 100644 --- a/drivers/mtd/nand/fsl_elbc_nand.c +++ b/drivers/mtd/nand/fsl_elbc_nand.c @@ -109,20 +109,6 @@ static struct nand_ecclayout fsl_elbc_oob_lp_eccm1 = { }; /* - * fsl_elbc_oob_lp_eccm* specify that LP NAND's OOB free area starts at offset - * 1, so we have to adjust bad block pattern. This pattern should be used for - * x8 chips only. So far hardware does not support x16 chips anyway. - */ -static u8 scan_ff_pattern[] = { 0xff, }; - -static struct nand_bbt_descr largepage_memorybased = { - .options = 0, - .offs = 0, - .len = 1, - .pattern = scan_ff_pattern, -}; - -/* * ELBC may use HW ECC, so that OOB offsets, that NAND core uses for bbt, * interfere with ECC positions, that's why we implement our own descriptors. * OOB {11, 5}, works for both SP and LP chips, with ECCM = 1 and ECCM = 0. @@ -699,7 +685,6 @@ static int fsl_elbc_chip_init_tail(struct mtd_info *mtd) chip->ecc.layout = (priv->fmr & FMR_ECCM) ? &fsl_elbc_oob_lp_eccm1 : &fsl_elbc_oob_lp_eccm0; - chip->badblock_pattern = &largepage_memorybased; } } else { dev_err(priv->dev,
Since the introduction of nand_create_default_bbt_descr() (now known as nand_create_badblock_pattern()) in commit 58373ff0afff4cc8ac40608872995f4d87eb72ec nand_chip.badblock_pattern will be dynamically calculated to the same 1-byte-length pattern that is required by fsl_elbc_nand. This custom badblock_pattern is no longer needed, then, and its removal may help facilitate further nand_bbt.c/nand_base.c cleanup in the future (one down, many to go?) Anyway, with nand_bbt.c fixed, this effectively reverts: commit 452db2724351ff3d9416a183a7955e00ab4e6ab4 [MTD] [NAND] fsl_elbc_nand: fix OOB workability for large page NAND chips Signed-off-by: Brian Norris <computersforpeace@gmail.com> Cc: Scott Wood <scottwood@freescale.com> --- Not even compile-tested... drivers/mtd/nand/fsl_elbc_nand.c | 15 --------------- 1 file changed, 15 deletions(-)