Patchwork [Quantal] ALSA: hda/via - don't report presence on HPs with no presence support

login
register
mail settings
Submitter Herton Ronaldo Krzesinski
Date Sept. 26, 2012, 1:25 p.m.
Message ID <1348665901-4570-1-git-send-email-herton.krzesinski@canonical.com>
Download mbox | patch
Permalink /patch/187080/
State New
Headers show

Comments

Herton Ronaldo Krzesinski - Sept. 26, 2012, 1:25 p.m.
If headphone jack can't detect plug presence, and we have the jack in
the jack table, snd_hda_jack_detect will return the plug as always
present (as it'll be considered as a phantom jack). The problem is that
when this happens, line out pins will always be disabled, resulting in
no sound if there are no headphones connected.

This was reported as a no sound problem after suspend on
http://bugs.launchpad.net/bugs/1052499, since the bug doesn't manifests
on first initialization before the phantom jack is added, but on resume
we reexecute the initialization code, and via_hp_automute starts
reporting HP always present with the jack now on the table.

BugLink: https://bugs.launchpad.net/bugs/1052499
Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
Cc: <stable@vger.kernel.org> [v3.6+]
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry-picked from commit cf55e904516947597d75fd3844acc24891a95772 at
 git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
---
 sound/pci/hda/patch_via.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

The patch was marked for 3.6 stable, but we are affected on Quantal since
we picked commit 80c8bfbe76869bfd6bdf3d260d316e7a32f318c3
Tim Gardner - Sept. 26, 2012, 1:37 p.m.

Patch

diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
index 74fb6fd..5a45a91 100644
--- a/sound/pci/hda/patch_via.c
+++ b/sound/pci/hda/patch_via.c
@@ -1672,7 +1672,8 @@  static void via_hp_automute(struct hda_codec *codec)
 	struct via_spec *spec = codec->spec;
 
 	if (!spec->hp_independent_mode && spec->autocfg.hp_pins[0] &&
-	    (spec->codec_type != VT1708 || spec->vt1708_jack_detect))
+	    (spec->codec_type != VT1708 || spec->vt1708_jack_detect) &&
+	    is_jack_detectable(codec, spec->autocfg.hp_pins[0]))
 		present = snd_hda_jack_detect(codec, spec->autocfg.hp_pins[0]);
 
 	if (spec->smart51_enabled)