From patchwork Wed Sep 26 08:43:43 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcus Shawcroft X-Patchwork-Id: 186993 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id D66E02C007F for ; Wed, 26 Sep 2012 18:44:07 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1349253848; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=hXJhIxB2WNzOgolan117X+Y+FsA=; b=t+So3ZAxt6QxfYZ wveVBgeZuIXW7NbLO5QWplpiPOmnOqkI7t828FeVRKQQIzMDSnf1j3qGnHxCLHD2 8i2L+n4PilB+dvBcQxlcTJbxP71C99ID/SqMTvuWjxScASJQ3lZEMHeJx354p8AH E9H7PjQ/bkm7XkygIbgAIC+PBa54= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:X-MC-Unique:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=y26RhEmhXoqRgCiCrreppDc4KtGyjvWW5IVKY+VXS1t3p1Rv03wziYMlteIeck MnrPUOdKkYw4O+z36hwj4KbAecIfJbpUrSYi60nO4wCBN6sbGl6pjwSs9Bj0m2fY U4UKXJwv4W37NgaV1VN/n/bYo+vvv4b2z1tOZvROLIqgE=; Received: (qmail 4999 invoked by alias); 26 Sep 2012 08:44:01 -0000 Received: (qmail 4984 invoked by uid 22791); 26 Sep 2012 08:44:00 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Sep 2012 08:43:46 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Wed, 26 Sep 2012 09:43:44 +0100 Received: from [10.1.72.50] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 26 Sep 2012 09:43:44 +0100 Message-ID: <5062C03F.5030209@arm.com> Date: Wed, 26 Sep 2012 09:43:43 +0100 From: Marcus Shawcroft User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20 MIME-Version: 1.0 To: tejas.belagod@arm.com CC: gcc-patches@gcc.gnu.org, Michael Hope , Marcin Juszkiewicz Subject: Re: [Patch][AArch64] Tighten predicate for CMP pattern. References: <504E0323.6020100@arm.com> In-Reply-To: <504E0323.6020100@arm.com> X-MC-Unique: 112092609434415101 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 10/09/12 16:11, Tejas Belagod wrote: > Hi, > > This patch tightens the predicate for the CMP pattern. It makes it restrictive > to accept reg or zero as prescribed by the architecture. > > Regression-tested on aarch64-none-elf. OK for aarch64-branch? > > Thanks, > Tejas Belagod > ARM. > > PS: This patch applies over vldn-vstn.txt sent out earlier. > > Changelog: > > 2012-09-10 Tejas Belagod > > gcc/ > * config/aarch64/aarch64-simd.md (aarch64_cm): Tighten > predicate for operand 2 of the compare pattern to accept register > or zero. > * config/aarch64/predicates.md (aarch64_simd_reg_or_zero): New. Tejas This patch duplicated the definition of aarch64_simd_reg_or_zero introduced by the earlier vld234 patch. I've committed the attached fix to aarch64-branch and aarch64-4.7-branch Cheers /Marcus 2012-09-26 Marcus Shawcroft * config/aarch64/predicates.md (aarch64_simd_reg_or_zero): Remove duplicate. Index: gcc/config/aarch64/predicates.md =================================================================== --- gcc/config/aarch64/predicates.md (revision 191754) +++ gcc/config/aarch64/predicates.md (working copy) @@ -295,9 +295,3 @@ { return aarch64_simd_imm_zero_p (op, mode); }) - -(define_predicate "aarch64_simd_reg_or_zero" - (and (match_code "reg,subreg,const_int,const_vector") - (ior (match_operand 0 "register_operand") - (ior (match_test "op == const0_rtx") - (match_test "aarch64_simd_imm_zero_p (op, mode)")))))