From patchwork Wed Sep 26 08:10:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [V3] mtd: basic (read only) driver for BCMA serial flash From: Artem Bityutskiy X-Patchwork-Id: 186982 Message-Id: <1348647058.24309.33.camel@sauron.fi.intel.com> To: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= Cc: linux-mtd@lists.infradead.org Date: Wed, 26 Sep 2012 11:10:58 +0300 On Wed, 2012-09-26 at 09:55 +0200, Rafał Miłecki wrote: > 2012/9/26 Artem Bityutskiy : > > On Mon, 2012-09-17 at 11:50 +0200, Rafał Miłecki wrote: > >> This registers MTD driver for serial flash platform device. Right now it > >> supports reading only, writing still has to be implemented. > >> > >> Signed-off-by: Rafał Miłecki > > > > Can you please confirm that you tested this and the driver works in R/O > > mode just fine. If yes, I would also like to add a note that this is R/O > > to the Kconfig text. If it does not even work, I am willing to drop it. > > OFC it works! :) It nicely cooperates with bcm47xxpart (partitions are > detected) and I can read mtd content (bootloader, nvram, etc.). > > You're right, we miss info about R/O in Kconfig, I didn't think about this. I've just folded the following changes in: diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig index ce6e3d4..27f80cd 100644 --- a/drivers/mtd/devices/Kconfig +++ b/drivers/mtd/devices/Kconfig @@ -121,12 +121,12 @@ config MTD_SST25L if you want to specify device partitioning. config MTD_BCM47XXSFLASH - tristate "Support for serial flash on BCMA bus" + tristate "R/O support for serial flash on BCMA bus" depends on BCMA_SFLASH help BCMA bus can have various flash memories attached, they are registered by bcma as platform devices. This enables driver for - serial flash memories. + serial flash memories (only read-only mode is implemented). config MTD_SLRAM tristate "Uncached system RAM"