From patchwork Wed Sep 26 08:10:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Artem Bityutskiy X-Patchwork-Id: 186982 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5962D2C0081 for ; Wed, 26 Sep 2012 18:11:49 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TGmhs-0007QR-2G; Wed, 26 Sep 2012 08:10:56 +0000 Received: from mga01.intel.com ([192.55.52.88]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TGmhp-0007Ph-JE for linux-mtd@lists.infradead.org; Wed, 26 Sep 2012 08:10:54 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 26 Sep 2012 01:10:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,489,1344236400"; d="asc'?scan'208";a="226895093" Received: from linux.jf.intel.com (HELO linux.intel.com) ([10.23.219.25]) by fmsmga002.fm.intel.com with ESMTP; 26 Sep 2012 01:10:51 -0700 Received: from [10.237.72.162] (sauron.fi.intel.com [10.237.72.162]) by linux.intel.com (Postfix) with ESMTP id 03A722C8001; Wed, 26 Sep 2012 01:10:51 -0700 (PDT) Message-ID: <1348647058.24309.33.camel@sauron.fi.intel.com> Subject: Re: [PATCH V3] mtd: basic (read only) driver for BCMA serial flash From: Artem Bityutskiy To: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= Date: Wed, 26 Sep 2012 11:10:58 +0300 In-Reply-To: References: <1347875449-19318-1-git-send-email-zajec5@gmail.com> <1348645345.24309.24.camel@sauron.fi.intel.com> X-Mailer: Evolution 3.4.4 (3.4.4-1.fc17) Mime-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -5.0 (-----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-5.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dedekind1[at]gmail.com) -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [192.55.52.88 listed in list.dnswl.org] 0.0 DKIM_ADSP_CUSTOM_MED No valid author signature, adsp_override is CUSTOM_MED 0.8 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (dedekind1[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 FSL_FREEMAIL_2 FSL_FREEMAIL_2 0.0 FSL_FREEMAIL_1 FSL_FREEMAIL_1 0.9 NML_ADSP_CUSTOM_MED ADSP custom_med hit, and not from a mailing list Cc: linux-mtd@lists.infradead.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Wed, 2012-09-26 at 09:55 +0200, Rafał Miłecki wrote: > 2012/9/26 Artem Bityutskiy : > > On Mon, 2012-09-17 at 11:50 +0200, Rafał Miłecki wrote: > >> This registers MTD driver for serial flash platform device. Right now it > >> supports reading only, writing still has to be implemented. > >> > >> Signed-off-by: Rafał Miłecki > > > > Can you please confirm that you tested this and the driver works in R/O > > mode just fine. If yes, I would also like to add a note that this is R/O > > to the Kconfig text. If it does not even work, I am willing to drop it. > > OFC it works! :) It nicely cooperates with bcm47xxpart (partitions are > detected) and I can read mtd content (bootloader, nvram, etc.). > > You're right, we miss info about R/O in Kconfig, I didn't think about this. I've just folded the following changes in: diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig index ce6e3d4..27f80cd 100644 --- a/drivers/mtd/devices/Kconfig +++ b/drivers/mtd/devices/Kconfig @@ -121,12 +121,12 @@ config MTD_SST25L if you want to specify device partitioning. config MTD_BCM47XXSFLASH - tristate "Support for serial flash on BCMA bus" + tristate "R/O support for serial flash on BCMA bus" depends on BCMA_SFLASH help BCMA bus can have various flash memories attached, they are registered by bcma as platform devices. This enables driver for - serial flash memories. + serial flash memories (only read-only mode is implemented). config MTD_SLRAM tristate "Uncached system RAM"