Patchwork scripts: unset LIBRARY_PATH and LPATH

login
register
mail settings
Submitter Erik Inge Bolsø
Date May 13, 2012, 12:21 a.m.
Message ID <alpine.BSF.2.00.1205130131550.21551@anduin.net>
Download mbox | patch
Permalink /patch/186872/
State Accepted
Commit e43643e41fb9
Headers show

Comments

Erik Inge Bolsø - May 13, 2012, 12:21 a.m.
Fooling around with crosstool-ng hg version, I happened to get gcc 
configure to yell at me right off. Promising.

The breakage is in build-cc-core-pass-2, saying
[ERROR]    configure: error: 
[CFG  ]    *** LIBRARY_PATH shouldn't contain the current directory when
[CFG  ]    *** building gcc. Please change the environment variable
[CFG  ]    *** and run configure again.

I figure this could bite others, and I see no good reason for LIBRARY_PATH 
to be set at this point.

The reason I had them set in the first place was due to some nvidia OpenCL 
libraries.

Patch attached to unset these two.

--
-erik	http://useofwords.blogspot.com/
# HG changeset patch
# User Erik Inge Bolsø <knan-ct@anduin.net>
# Date 1336864160 -7200
# Node ID 4cc441b115867faaf37b89629209ebde734e3b06
# Parent  c800b7d6a50c267c3e0a64829da4b082e260deff
scripts: unset LIBRARY_PATH and LPATH

These environment variables set search path for gcc at link time, which can break the build.

Signed-off-by: Erik Inge Bolsø <knan-ct@anduin.net>
--
For unsubscribe information see http://sourceware.org/lists.html#faq
Yann E. MORIN - Sept. 25, 2012, 9:04 p.m.
Erik, All,

On Tuesday 25 September 2012 22:45:47 Yann E. MORIN wrote:
> Your patch:
>     scripts: unset LIBRARY_PATH and LPATH
> 
> has been applied as #e43643e41fb9. Thank you!

Sorry it took so long to apply your patch.

Next time, would you please use 'hg email' to send your patches, that will
send the patches in-line so it's easier to review and catch my eye).
There a tuto on how to do that in: docs/C - Misc. tutorials.txt.

Thank you!

Regards,
Yann E. MORIN.

PS. It seems my send-an-email-for-applied-patches script is now working! :-)
YEM.

Patch

diff --git a/scripts/crosstool-NG.sh.in b/scripts/crosstool-NG.sh.in

--- a/scripts/crosstool-NG.sh.in

+++ b/scripts/crosstool-NG.sh.in

@@ -39,6 +39,10 @@ 

 CT_TestAndAbort "Don't set LD_LIBRARY_PATH. It screws up the build." -n "${LD_LIBRARY_PATH}"
 CT_TestAndAbort "Don't set CFLAGS. It screws up the build." -n "${CFLAGS}"
 CT_TestAndAbort "Don't set CXXFLAGS. It screws up the build." -n "${CXXFLAGS}"
+CT_Test "LIBRARY_PATH screws up the build. Resetting." -n "${LIBRARY_PATH}"

+export LIBRARY_PATH=

+CT_Test "LPATH screws up the build. Resetting." -n "$LPATH"

+export LPATH=

 CT_Test "GREP_OPTIONS screws up the build. Resetting." -n "${GREP_OPTIONS}"
 export GREP_OPTIONS=
 # Workaround against openSUSE 12.1 that breaks ./configure for cross-compilation: