From patchwork Tue Sep 25 12:56:03 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 186808 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7E9A12C007A for ; Tue, 25 Sep 2012 22:58:25 +1000 (EST) Received: from localhost ([::1]:40369 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGUiV-0007AP-PJ for incoming@patchwork.ozlabs.org; Tue, 25 Sep 2012 08:58:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGUhM-0004ls-KT for qemu-devel@nongnu.org; Tue, 25 Sep 2012 08:57:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGUhG-0001Bt-IK for qemu-devel@nongnu.org; Tue, 25 Sep 2012 08:57:12 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:65329) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGUhG-0000zu-Cl for qemu-devel@nongnu.org; Tue, 25 Sep 2012 08:57:06 -0400 Received: by mail-pb0-f45.google.com with SMTP id rp2so67620pbb.4 for ; Tue, 25 Sep 2012 05:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:x-mailer:in-reply-to :references; bh=eYJ8Hwrvgn8LvKkwE7bW4BmBdwAQZdP8knvl8vCF5Ks=; b=dhxRdpl7ctsNchKfEOEmLLrIgxefvu2K9Z65evz7GcwbUhVzJzCXkJYHOWWjYWuwgn mm5yhOIPIOA2E+dZgcfAZZ9JfNAcFkkS9hWjeDNlS87jOvhuuBC1qS+r0m7Uc9xxyvCZ sFh1JjZWR1HEm0CGJU+8ckfIbrlG3M2mQ6oygd0JGe2bDqNqjanrGyyzGOW8xeXqRB8G k2cXb0IW6i4ncpuv4FJ1GlPvAutOx4BH5QK/ftj04NxKQ8+JSQAa8rEMT763IY0pra7p SIeeCyV8EA7l8HfAkpVGPSy8RNnBoDTRkznc2+4wsJm2JQ39sVXphMx17sJHz2ritw4S Y+dg== Received: by 10.68.213.199 with SMTP id nu7mr5118820pbc.75.1348577825983; Tue, 25 Sep 2012 05:57:05 -0700 (PDT) Received: from yakj.usersys.redhat.com (93-34-169-1.ip50.fastwebnet.it. [93.34.169.1]) by mx.google.com with ESMTPS id py9sm309335pbb.20.2012.09.25.05.57.02 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 25 Sep 2012 05:57:04 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 25 Sep 2012 14:56:03 +0200 Message-Id: <1348577763-12920-18-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.12 In-Reply-To: <1348577763-12920-1-git-send-email-pbonzini@redhat.com> References: <1348577763-12920-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.160.45 Subject: [Qemu-devel] [PATCH 17/17] linux-aio: use event notifiers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Since linux-aio already uses an eventfd, converting it to use the EventNotifier-based API simplifies the code even though it is not meant to be portable. Reviewed-by: Anthony Liguori Signed-off-by: Paolo Bonzini --- linux-aio.c | 49 +++++++++++++++++++------------------------------ 1 file modificato, 19 inserzioni(+), 30 rimozioni(-) diff --git a/linux-aio.c b/linux-aio.c index ce9b5d4..769b558 100644 --- a/linux-aio.c +++ b/linux-aio.c @@ -10,8 +10,8 @@ #include "qemu-common.h" #include "qemu-aio.h" #include "block/raw-posix-aio.h" +#include "event_notifier.h" -#include #include /* @@ -37,7 +37,7 @@ struct qemu_laiocb { struct qemu_laio_state { io_context_t ctx; - int efd; + EventNotifier e; int count; }; @@ -76,29 +76,17 @@ static void qemu_laio_process_completion(struct qemu_laio_state *s, qemu_aio_release(laiocb); } -static void qemu_laio_completion_cb(void *opaque) +static void qemu_laio_completion_cb(EventNotifier *e) { - struct qemu_laio_state *s = opaque; + struct qemu_laio_state *s = container_of(e, struct qemu_laio_state, e); - while (1) { + while (event_notifier_test_and_clear(&s->e)) { struct io_event events[MAX_EVENTS]; - uint64_t val; - ssize_t ret; struct timespec ts = { 0 }; int nevents, i; do { - ret = read(s->efd, &val, sizeof(val)); - } while (ret == -1 && errno == EINTR); - - if (ret == -1 && errno == EAGAIN) - break; - - if (ret != 8) - break; - - do { - nevents = io_getevents(s->ctx, val, MAX_EVENTS, events, &ts); + nevents = io_getevents(s->ctx, MAX_EVENTS, MAX_EVENTS, events, &ts); } while (nevents == -EINTR); for (i = 0; i < nevents; i++) { @@ -112,9 +100,9 @@ static void qemu_laio_completion_cb(void *opaque) } } -static int qemu_laio_flush_cb(void *opaque) +static int qemu_laio_flush_cb(EventNotifier *e) { - struct qemu_laio_state *s = opaque; + struct qemu_laio_state *s = container_of(e, struct qemu_laio_state, e); return (s->count > 0) ? 1 : 0; } @@ -146,8 +134,9 @@ static void laio_cancel(BlockDriverAIOCB *blockacb) * We might be able to do this slightly more optimal by removing the * O_NONBLOCK flag. */ - while (laiocb->ret == -EINPROGRESS) - qemu_laio_completion_cb(laiocb->ctx); + while (laiocb->ret == -EINPROGRESS) { + qemu_laio_completion_cb(&laiocb->ctx->e); + } } static AIOPool laio_pool = { @@ -186,7 +175,7 @@ BlockDriverAIOCB *laio_submit(BlockDriverState *bs, void *aio_ctx, int fd, __func__, type); goto out_free_aiocb; } - io_set_eventfd(&laiocb->iocb, s->efd); + io_set_eventfd(&laiocb->iocb, event_notifier_get_fd(&s->e)); s->count++; if (io_submit(s->ctx, 1, &iocbs) < 0) @@ -205,21 +194,21 @@ void *laio_init(void) struct qemu_laio_state *s; s = g_malloc0(sizeof(*s)); - s->efd = eventfd(0, 0); - if (s->efd == -1) + if (event_notifier_init(&s->e, false) < 0) { goto out_free_state; - fcntl(s->efd, F_SETFL, O_NONBLOCK); + } - if (io_setup(MAX_EVENTS, &s->ctx) != 0) + if (io_setup(MAX_EVENTS, &s->ctx) != 0) { goto out_close_efd; + } - qemu_aio_set_fd_handler(s->efd, qemu_laio_completion_cb, NULL, - qemu_laio_flush_cb, s); + qemu_aio_set_event_notifier(&s->e, qemu_laio_completion_cb, + qemu_laio_flush_cb); return s; out_close_efd: - close(s->efd); + event_notifier_cleanup(&s->e); out_free_state: g_free(s); return NULL;