Patchwork [13/17] aio: call aio_notify after setting I/O handlers

login
register
mail settings
Submitter Paolo Bonzini
Date Sept. 25, 2012, 12:55 p.m.
Message ID <1348577763-12920-14-git-send-email-pbonzini@redhat.com>
Download mbox | patch
Permalink /patch/186807/
State New
Headers show

Comments

Paolo Bonzini - Sept. 25, 2012, 12:55 p.m.
In the current code, this is done by qemu_set_fd_handler2, which is
called by qemu_aio_set_fd_handler.  We need to keep the same behavior
even after removing the call to qemu_set_fd_handler2.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 aio-posix.c | 2 ++
 aio-win32.c | 2 ++
 2 file modificati, 4 inserzioni(+)
Anthony Liguori - Sept. 25, 2012, 10:07 p.m.
Paolo Bonzini <pbonzini@redhat.com> writes:

> In the current code, this is done by qemu_set_fd_handler2, which is
> called by qemu_aio_set_fd_handler.  We need to keep the same behavior
> even after removing the call to qemu_set_fd_handler2.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori


> ---
>  aio-posix.c | 2 ++
>  aio-win32.c | 2 ++
>  2 file modificati, 4 inserzioni(+)
>
> diff --git a/aio-posix.c b/aio-posix.c
> index e29ece9..41f638f 100644
> --- a/aio-posix.c
> +++ b/aio-posix.c
> @@ -90,6 +90,8 @@ void aio_set_fd_handler(AioContext *ctx,
>          node->pfd.events |= (io_read ? G_IO_IN | G_IO_HUP : 0);
>          node->pfd.events |= (io_write ? G_IO_OUT : 0);
>      }
> +
> +    aio_notify(ctx);
>  }
>  
>  void aio_set_event_notifier(AioContext *ctx,
> diff --git a/aio-win32.c b/aio-win32.c
> index 5057371..78faf69 100644
> --- a/aio-win32.c
> +++ b/aio-win32.c
> @@ -75,6 +75,8 @@ void aio_set_event_notifier(AioContext *ctx,
>          node->io_notify = io_notify;
>          node->io_flush = io_flush;
>      }
> +
> +    aio_notify(ctx);
>  }
>  
>  bool aio_pending(AioContext *ctx)
> -- 
> 1.7.12

Patch

diff --git a/aio-posix.c b/aio-posix.c
index e29ece9..41f638f 100644
--- a/aio-posix.c
+++ b/aio-posix.c
@@ -90,6 +90,8 @@  void aio_set_fd_handler(AioContext *ctx,
         node->pfd.events |= (io_read ? G_IO_IN | G_IO_HUP : 0);
         node->pfd.events |= (io_write ? G_IO_OUT : 0);
     }
+
+    aio_notify(ctx);
 }
 
 void aio_set_event_notifier(AioContext *ctx,
diff --git a/aio-win32.c b/aio-win32.c
index 5057371..78faf69 100644
--- a/aio-win32.c
+++ b/aio-win32.c
@@ -75,6 +75,8 @@  void aio_set_event_notifier(AioContext *ctx,
         node->io_notify = io_notify;
         node->io_flush = io_flush;
     }
+
+    aio_notify(ctx);
 }
 
 bool aio_pending(AioContext *ctx)