Patchwork external-toolchain: BR2_TOOLCHAIN_EXTERNAL_GLIBC includes eglibc

login
register
mail settings
Submitter Baruch Siach
Date Sept. 25, 2012, 3:49 a.m.
Message ID <1348544993-5682-1-git-send-email-baruch@tkos.co.il>
Download mbox | patch
Permalink /patch/186686/
State Superseded
Headers show

Comments

Baruch Siach - Sept. 25, 2012, 3:49 a.m.
Yann E. MORIN says:

    "Although eglibc can be configured to include/exclude parts of the
    features, it seems to not be in wide use, if at all."

Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 toolchain/toolchain-external/Config.in |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Thomas Petazzoni - Sept. 25, 2012, 7:54 a.m.
Dear Baruch Siach,

On Tue, 25 Sep 2012 05:49:53 +0200, Baruch Siach wrote:

> +	  Note: eglibc is a variant of glibc that (among other things) can be
> +	  configured to exclude parts of its features. This capability is 
> +	  currently not supported.

This note makes no sense in the context of external toolchains: the C
library is already compiled into the external toolchain, so it's the
responsibility of the person building the external toolchain to know
how to configure eglibc. The fact that we don't support eglibc
configuration in Buildroot doesn't make much sense.

Or, if you want to mean that we don't support eglibc toolchains that
have been configured to leave out certain features (such as IPv6
support for example), then it should be said in a different way, such
as: "We only support eglibc toolchains providing this, that and this
other feature".

Best regards,

Thomas
Baruch Siach - Sept. 25, 2012, 8:33 a.m.
Hi Thomas,

On Tue, Sep 25, 2012 at 09:54:42AM +0200, Thomas Petazzoni wrote:
> Dear Baruch Siach,
> 
> On Tue, 25 Sep 2012 05:49:53 +0200, Baruch Siach wrote:
> 
> > +	  Note: eglibc is a variant of glibc that (among other things) can be
> > +	  configured to exclude parts of its features. This capability is 
> > +	  currently not supported.
> 
> This note makes no sense in the context of external toolchains: the C
> library is already compiled into the external toolchain, so it's the
> responsibility of the person building the external toolchain to know
> how to configure eglibc. The fact that we don't support eglibc
> configuration in Buildroot doesn't make much sense.
> 
> Or, if you want to mean that we don't support eglibc toolchains that
> have been configured to leave out certain features (such as IPv6
> support for example), then it should be said in a different way, such
> as: "We only support eglibc toolchains providing this, that and this
> other feature".

This is exactly what I meant to say, but the text surely needs to be clearer 
as you suggest. What feature do you think we need to mention as minimal 
requirements in the help text?

baruch
Thomas Petazzoni - Sept. 25, 2012, 8:39 a.m.
Dear Baruch Siach,

On Tue, 25 Sep 2012 10:33:30 +0200, Baruch Siach wrote:

> This is exactly what I meant to say, but the text surely needs to be clearer 
> as you suggest. What feature do you think we need to mention as minimal 
> requirements in the help text?

I have no idea, since I have never looked at what eglibc provides in
terms of configurability :) I guess Yann can give details on this, he
is quite certainly a lot more aware than I am about what the eglibc
options are.

Best regards,

Thomas
Baruch Siach - Sept. 25, 2012, 1:46 p.m.
Hi Thomas,

On Tue, Sep 25, 2012 at 10:39:52AM +0200, Thomas Petazzoni wrote:
> Dear Baruch Siach,
> 
> On Tue, 25 Sep 2012 10:33:30 +0200, Baruch Siach wrote:
> 
> > This is exactly what I meant to say, but the text surely needs to be clearer 
> > as you suggest. What feature do you think we need to mention as minimal 
> > requirements in the help text?
> 
> I have no idea, since I have never looked at what eglibc provides in
> terms of configurability :) I guess Yann can give details on this, he
> is quite certainly a lot more aware than I am about what the eglibc
> options are.

Well, after a little thought, maybe we shouldn't get into configuration 
details here and just say something general like: "Warning: using a toolchain 
with eglibc configuration lacking key features (examples?) may result in build 
failures, depending on your choice of packages."

baruch

Patch

diff --git a/toolchain/toolchain-external/Config.in b/toolchain/toolchain-external/Config.in
index f86ed74..f7a84b2 100644
--- a/toolchain/toolchain-external/Config.in
+++ b/toolchain/toolchain-external/Config.in
@@ -664,8 +664,12 @@  config BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC
 	select BR2_TOOLCHAIN_HAS_SHADOW_PASSWORDS
 
 config BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC
-	bool "glibc"
+	bool "glibc/eglibc"
 	select BR2_TOOLCHAIN_EXTERNAL_GLIBC
+	help
+	  Note: eglibc is a variant of glibc that (among other things) can be
+	  configured to exclude parts of its features. This capability is 
+	  currently not supported.
 
 endchoice