Patchwork [Quantal] pull-request: revert i915 backlight patches

login
register
mail settings
Submitter Zhang, Xiong Y
Date Sept. 25, 2012, 2:13 a.m.
Message ID <8082FF9BCB2B054996454E47167FF4ECC3A1F6@SHSMSX102.ccr.corp.intel.com>
Download mbox
Permalink /patch/186673/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/kamal/ubuntu-quantal.git backlight-revert

Comments

Zhang, Xiong Y - Sept. 25, 2012, 2:13 a.m.
Hi, Kamal:

   Please help report this issue to freedesktop.org bugzilla. 
   Or else these commits will be contained in next upstream release.

Thanks

-----Original Message-----
From: kernel-team-bounces@lists.ubuntu.com [mailto:kernel-team-bounces@lists.ubuntu.com] On Behalf Of Kamal Mostafa
Sent: Tuesday, September 25, 2012 3:00 AM
To: kernel-team@lists.ubuntu.com
Subject: [Quantal] pull-request: revert i915 backlight patches

This set of commit(s) causes black screen on boot issues on some machines, and breaks backlight controls after suspend/resume on Dell XPS 13.

Bugs:

    BugLink: https://bugs.launchpad.net/bugs/1055665
    BugLink: https://bugs.launchpad.net/bugs/1053269
    BugLink: https://bugs.launchpad.net/bugs/1055231

Please apply this revert to Quantal.

Thanks (and sorry!)

 -Kamal
    

-----------

The following changes since commit 0ac9641dd1b4e607c1d7e8b8da424ac8256900de:

  UBUNTU: [Config] Disable CONFIG_DRM_AST (2012-09-21 11:50:24 -0700)

are available in the git repository at:

  git://kernel.ubuntu.com/kamal/ubuntu-quantal.git backlight-revert

for you to fetch changes up to c149cb4cc47197c41e99a5f67bc6bc1d37bbac4e:

  Revert "drm/i915: pnv has a backlight polarity control bit, too" (2012-09-24 11:44:04 -0700)

----------------------------------------------------------------
Kamal Mostafa (6):
      Revert "drm/i915: don't forget the PCH backlight registers"
      Revert "drm/i915: fix up PCH backlight #define mixup"
      Revert "drm/i915: allow pipe A for lvds on gen4"
      Revert "drm/i915: properly enable the blc controller on the right pipe"
      Revert "drm/i915: clear up backlight #define confusion on gen4+"
      Revert "drm/i915: pnv has a backlight polarity control bit, too"

 drivers/gpu/drm/i915/i915_reg.h    |   57 +++++++++++++-----------------------
 drivers/gpu/drm/i915/intel_drv.h   |    3 +-
 drivers/gpu/drm/i915/intel_lvds.c  |   34 ++++++++++++++++-----
 drivers/gpu/drm/i915/intel_panel.c |   51 +-------------------------------
 4 files changed, 48 insertions(+), 97 deletions(-)
Kamal Mostafa - Sept. 26, 2012, 3:36 p.m.
On Tue, 2012-09-25 at 02:13 +0000, Zhang, Xiong Y wrote:
> Hi, Kamal:
> 
>    Please help report this issue to freedesktop.org bugzilla. 
>    Or else these commits will be contained in next upstream release.

Hi Xiong-

But I don't have any reason to think that those commits are actually a
problem upstream.  These patches were basically the smallest set of
cherry-picks that fix backlight controls for some machines (specifically
for my target, the Dell XPS 13).

My supposition is that the patches caused trouble in Ubuntu Quantal due
to the lack of some additional upstream patch(es) that I missed.  I will
investigate and verify that in the near future, but I don't yet have any
evidence that there's any problem with them upstream.

 -Kamal



> Thanks
> 
> -----Original Message-----
> From: kernel-team-bounces@lists.ubuntu.com [mailto:kernel-team-bounces@lists.ubuntu.com] On Behalf Of Kamal Mostafa
> Sent: Tuesday, September 25, 2012 3:00 AM
> To: kernel-team@lists.ubuntu.com
> Subject: [Quantal] pull-request: revert i915 backlight patches
> 
> This set of commit(s) causes black screen on boot issues on some machines, and breaks backlight controls after suspend/resume on Dell XPS 13.
> 
> Bugs:
> 
>     BugLink: https://bugs.launchpad.net/bugs/1055665
>     BugLink: https://bugs.launchpad.net/bugs/1053269
>     BugLink: https://bugs.launchpad.net/bugs/1055231
> 
> Please apply this revert to Quantal.
> 
> Thanks (and sorry!)
> 
>  -Kamal
>     
> 
> -----------
> 
> The following changes since commit 0ac9641dd1b4e607c1d7e8b8da424ac8256900de:
> 
>   UBUNTU: [Config] Disable CONFIG_DRM_AST (2012-09-21 11:50:24 -0700)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/kamal/ubuntu-quantal.git backlight-revert
> 
> for you to fetch changes up to c149cb4cc47197c41e99a5f67bc6bc1d37bbac4e:
> 
>   Revert "drm/i915: pnv has a backlight polarity control bit, too" (2012-09-24 11:44:04 -0700)
> 
> ----------------------------------------------------------------
> Kamal Mostafa (6):
>       Revert "drm/i915: don't forget the PCH backlight registers"
>       Revert "drm/i915: fix up PCH backlight #define mixup"
>       Revert "drm/i915: allow pipe A for lvds on gen4"
>       Revert "drm/i915: properly enable the blc controller on the right pipe"
>       Revert "drm/i915: clear up backlight #define confusion on gen4+"
>       Revert "drm/i915: pnv has a backlight polarity control bit, too"
> 
>  drivers/gpu/drm/i915/i915_reg.h    |   57 +++++++++++++-----------------------
>  drivers/gpu/drm/i915/intel_drv.h   |    3 +-
>  drivers/gpu/drm/i915/intel_lvds.c  |   34 ++++++++++++++++-----
>  drivers/gpu/drm/i915/intel_panel.c |   51 +-------------------------------
>  4 files changed, 48 insertions(+), 97 deletions(-)
>