| Message ID | 201209250300.34648.marex@denx.de |
|---|---|
| State | RFC |
| Headers | show |
On Mon, Sep 24, 2012 at 10:00 PM, Marek Vasut <marex@denx.de> wrote: > Dear Eric Nelson, > >> On 09/24/2012 05:22 PM, Tom Rini wrote: >> > On Mon, Sep 24, 2012 at 09:03:27PM -0300, Fabio Estevam wrote: >> >> On Wed, Sep 19, 2012 at 5:20 PM, Tom Rini<trini@ti.com> wrote: >> >>> I lmgtfy.com'd Marek, but for everyone, >> >>> http://lists.denx.de/pipermail/u-boot/2012-July/127260.html is the >> >>> start of the thread. >> >> >> >> I am still getting the same issue on 2012.10-rc1. >> >> >> >> Is anyone else having issues to load a kernel with 2012.10-rc1 on >> >> sabrelite? >> > >> > I bet everyone with a sufficiently recent toolchain is. I'm seeing this >> > on TI boards when I use the Linaro toolchain rather than ELDK-5.2. >> > Albert, what do you want to do about this? >> >> That adds up, since I've been building with an old one (4.4) and >> haven't been seeing resets. > > For starters (as proof-of-concept) ... try this patch ... With this patch I can get U-boot 2012.10-rc1 (built with arm-linux-gnueabi-gcc (Ubuntu/Linaro 4.6.3-1ubuntu5)) to load the kernel. Using gcc 4.4 I don't see any problem with 2012.10-rc1. Regards, Fabio Estevam
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/24/12 18:00, Marek Vasut wrote: > Dear Eric Nelson, > >> On 09/24/2012 05:22 PM, Tom Rini wrote: >>> On Mon, Sep 24, 2012 at 09:03:27PM -0300, Fabio Estevam wrote: >>>> On Wed, Sep 19, 2012 at 5:20 PM, Tom Rini<trini@ti.com> >>>> wrote: >>>>> I lmgtfy.com'd Marek, but for everyone, >>>>> http://lists.denx.de/pipermail/u-boot/2012-July/127260.html >>>>> is the start of the thread. >>>> >>>> I am still getting the same issue on 2012.10-rc1. >>>> >>>> Is anyone else having issues to load a kernel with >>>> 2012.10-rc1 on sabrelite? >>> >>> I bet everyone with a sufficiently recent toolchain is. I'm >>> seeing this on TI boards when I use the Linaro toolchain rather >>> than ELDK-5.2. Albert, what do you want to do about this? >> >> That adds up, since I've been building with an old one (4.4) and >> haven't been seeing resets. > > For starters (as proof-of-concept) ... try this patch ... > > diff --git a/common/fdt_support.c b/common/fdt_support.c index > 593f16c..63a5999 100644 --- a/common/fdt_support.c +++ > b/common/fdt_support.c @@ -449,10 +449,12 @@ void > fdt_fixup_ethernet(void *fdt) { int node, i, j; char enet[16], > *tmp, *end; - char mac[16] = "ethaddr"; + char > mac[16]; const char *path; unsigned char mac_addr[6]; > > + sprintf(mac, "ethaddr"); + node = fdt_path_offset(fdt, > "/aliases"); if (node < 0) return; This, and a similar patch to fs/ubifs/super.c are the right way to go, I think. Please submit this properly, thanks! - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQIcBAEBAgAGBQJQYdw8AAoJENk4IS6UOR1WgD0P/RqYVXpmLdaRbAyuofsvAdTs xR2t1ccpaGRGtWkYigSHvS0WhdNj9M+EAGG8IqKpmy4Txietm9ahrzOQgfVg24h/ i70FPwTiqQiEVXfEf9SzR1WFdN+7f5YzlOAGPIjBbj6j/gL8lSgR0T6LNJwT4BfZ t7CJPCdZmufAgQvIa2gKxRByju4wpRJxJ61FjdfVBbWBJ2pTqVUZI72FHLMaZ+In o+P9LYt02w/GK4vfFcb8/zaVfiK5cCPTgJMJ5i3F5ktKESp37jySeCrDLWwJsqRU wVBg5nOkWyXGGuY7qrFKAuJl2RA52k9ZolQeUepXR/YJsK+AGieX1qXNq+w2n6iz E49jV4uWELdP/60kcM9m8QUG7M2eZj9hDvEVG1n6SyQeRQ0GJ1Y4PFYCpn4/7+N3 WfyZVKk0y1yWWZAL+sCIGfaAHaSqiqPLxmQPbtGLJHS93jNRGSFDMTjaY+NOL9sn 8jvbrU6r3OsscJA8X2O2mtFwOjJKTbSsJth681295kwq3gYG2Ba+xBBQagxcXgdr ajbANS5uvw30Z3SJsttDta15mnHgJGYzRmYCo5kSHGA5+xZ40RWZKhd9ZlNDG8xA 7mXWdYjCpIKT7YHzQeinf/xiyKiIel2F7eoCw8uEEZengxfXOhZld6dNAA7jPU+L ZzsIIRSYq8SB/PeCJHzi =sNN7 -----END PGP SIGNATURE-----
Dear Tom Rini, > On 09/24/12 18:00, Marek Vasut wrote: > > Dear Eric Nelson, > > > >> On 09/24/2012 05:22 PM, Tom Rini wrote: > >>> On Mon, Sep 24, 2012 at 09:03:27PM -0300, Fabio Estevam wrote: > >>>> On Wed, Sep 19, 2012 at 5:20 PM, Tom Rini<trini@ti.com> > >>>> > >>>> wrote: > >>>>> I lmgtfy.com'd Marek, but for everyone, > >>>>> http://lists.denx.de/pipermail/u-boot/2012-July/127260.html > >>>>> is the start of the thread. > >>>> > >>>> I am still getting the same issue on 2012.10-rc1. > >>>> > >>>> Is anyone else having issues to load a kernel with > >>>> 2012.10-rc1 on sabrelite? > >>> > >>> I bet everyone with a sufficiently recent toolchain is. I'm > >>> seeing this on TI boards when I use the Linaro toolchain rather > >>> than ELDK-5.2. Albert, what do you want to do about this? > >> > >> That adds up, since I've been building with an old one (4.4) and > >> haven't been seeing resets. > > > > For starters (as proof-of-concept) ... try this patch ... > > > > diff --git a/common/fdt_support.c b/common/fdt_support.c index > > 593f16c..63a5999 100644 --- a/common/fdt_support.c +++ > > b/common/fdt_support.c @@ -449,10 +449,12 @@ void > > fdt_fixup_ethernet(void *fdt) { int node, i, j; char enet[16], > > *tmp, *end; - char mac[16] = "ethaddr"; + char > > mac[16]; const char *path; unsigned char mac_addr[6]; > > > > + sprintf(mac, "ethaddr"); + node = fdt_path_offset(fdt, > > "/aliases"); if (node < 0) return; > > This, and a similar patch to fs/ubifs/super.c are the right way to go, > I think. Please submit this properly, thanks! I don't think so ... I'm still reading the C spec, give me some time, it's not exactly your usual good night light reading, you know ... Best regards, Marek Vasut
diff --git a/common/fdt_support.c b/common/fdt_support.c index 593f16c..63a5999 100644 --- a/common/fdt_support.c +++ b/common/fdt_support.c @@ -449,10 +449,12 @@ void fdt_fixup_ethernet(void *fdt) { int node, i, j; char enet[16], *tmp, *end; - char mac[16] = "ethaddr"; + char mac[16]; const char *path; unsigned char mac_addr[6]; + sprintf(mac, "ethaddr"); + node = fdt_path_offset(fdt, "/aliases"); if (node < 0) return;