From patchwork Tue Sep 25 00:23:27 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Haicheng Li X-Patchwork-Id: 186639 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 159092C008A for ; Tue, 25 Sep 2012 10:24:12 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751677Ab2IYAXb (ORCPT ); Mon, 24 Sep 2012 20:23:31 -0400 Received: from mga11.intel.com ([192.55.52.93]:4865 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751171Ab2IYAXa (ORCPT ); Mon, 24 Sep 2012 20:23:30 -0400 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 24 Sep 2012 17:23:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,478,1344236400"; d="scan'208,223";a="226211038" Received: from unknown (HELO hli22-desktop.sh.intel.com) ([10.239.77.107]) by fmsmga002.fm.intel.com with ESMTP; 24 Sep 2012 17:23:28 -0700 Message-ID: <5060F97F.3040809@linux.intel.com> Date: Tue, 25 Sep 2012 08:23:27 +0800 From: Haicheng Li User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.28) Gecko/20120306 Thunderbird/3.1.20 MIME-Version: 1.0 To: Haicheng Li , "David S. Miller" , netdev@vger.kernel.org CC: Takahiroi Shimizu , "linux-kernel@vger.kernel.org" , haicheng.lee@gmail.com Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency. References: <506009A4.8000202@linux.intel.com> In-Reply-To: <506009A4.8000202@linux.intel.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From 898e3214b3406c620571cedf704719784b0df049 Mon Sep 17 00:00:00 2001 From: Haicheng Li Date: Mon, 24 Sep 2012 15:52:30 +0800 Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency. The .config is: CONFIG_PCH_GBE=y CONFIG_PCH_PTP=y CONFIG_PTP_1588_CLOCK=m The build error: drivers/built-in.o: In function `pch_tx_timestamp': .../pch_gbe_main.c:215: undefined reference to `pch_ch_event_read' .../pch_gbe_main.c:225: undefined reference to `pch_tx_snap_read' .../pch_gbe_main.c:231: undefined reference to `pch_ch_event_write' .../pch_gbe_main.c:170: undefined reference to `pch_ch_event_read' .../pch_gbe_main.c:175: undefined reference to `pch_src_uuid_lo_read' .../pch_gbe_main.c:176: undefined reference to `pch_src_uuid_hi_read' .../pch_gbe_main.c:190: undefined reference to `pch_ch_event_write' .../pch_gbe_main.c:184: undefined reference to `pch_rx_snap_read' .../pch_gbe_main.c:267: undefined reference to `pch_ch_control_write' .../pch_gbe_main.c:271: undefined reference to `pch_ch_control_write' .../pch_gbe_main.c:275: undefined reference to `pch_ch_control_write' .../pch_gbe_main.c:281: undefined reference to `pch_ch_control_write' .../pch_gbe_main.c:283: undefined reference to `pch_set_station_address' .../pch_gbe_main.c:290: undefined reference to `pch_ch_event_write' Signed-off-by: Haicheng Li --- drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig index bce0164..6c8aed4 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig +++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig @@ -26,7 +26,7 @@ if PCH_GBE config PCH_PTP bool "PCH PTP clock support" default n - depends on PTP_1588_CLOCK_PCH + depends on PTP_1588_CLOCK_PCH = PCH_GBE ---help--- Say Y here if you want to use Precision Time Protocol (PTP) in the driver. PTP is a method to precisely synchronize distributed clocks