Patchwork [3/7] target-s390x: Call tcg_gen_debug_insn_start

login
register
mail settings
Submitter Richard Henderson
Date Sept. 24, 2012, 9:55 p.m.
Message ID <1348523753-25083-4-git-send-email-rth@twiddle.net>
Download mbox | patch
Permalink /patch/186587/
State New
Headers show

Comments

Richard Henderson - Sept. 24, 2012, 9:55 p.m.
Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 target-s390x/translate.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
Aurelien Jarno - Sept. 25, 2012, 10:44 p.m.
On Mon, Sep 24, 2012 at 02:55:49PM -0700, Richard Henderson wrote:
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  target-s390x/translate.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/target-s390x/translate.c b/target-s390x/translate.c
> index 3214783..6fa76a0 100644
> --- a/target-s390x/translate.c
> +++ b/target-s390x/translate.c
> @@ -5173,10 +5173,11 @@ static inline void gen_intermediate_code_internal(CPUS390XState *env,
>          if (num_insns + 1 == max_insns && (tb->cflags & CF_LAST_IO)) {
>              gen_io_start();
>          }
> -#if defined(S390X_DEBUG_DISAS_VERBOSE)
> -        LOG_DISAS("pc " TARGET_FMT_lx "\n",
> -                  dc.pc);
> -#endif
> +
> +        if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP | CPU_LOG_TB_OP_OPT))) {
> +            tcg_gen_debug_insn_start(dc.pc);
> +        }
> +
>          disas_s390_insn(env, &dc);
>  
>          num_insns++;
> -- 
> 1.7.11.4
> 
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

Patch

diff --git a/target-s390x/translate.c b/target-s390x/translate.c
index 3214783..6fa76a0 100644
--- a/target-s390x/translate.c
+++ b/target-s390x/translate.c
@@ -5173,10 +5173,11 @@  static inline void gen_intermediate_code_internal(CPUS390XState *env,
         if (num_insns + 1 == max_insns && (tb->cflags & CF_LAST_IO)) {
             gen_io_start();
         }
-#if defined(S390X_DEBUG_DISAS_VERBOSE)
-        LOG_DISAS("pc " TARGET_FMT_lx "\n",
-                  dc.pc);
-#endif
+
+        if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP | CPU_LOG_TB_OP_OPT))) {
+            tcg_gen_debug_insn_start(dc.pc);
+        }
+
         disas_s390_insn(env, &dc);
 
         num_insns++;