From patchwork Mon Sep 24 21:41:38 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rong Xu X-Patchwork-Id: 186579 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 718F32C0082 for ; Tue, 25 Sep 2012 07:41:56 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1349127716; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Received:Received:To:Subject:Message-Id:Date: From:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=PaE5yrX MJCkUQbPlFVUfinynEz8=; b=y30/MQCjwz1ymks+gEdX/7e3mlgYVJ42wAbQeBc X7k6RgkF5wuFmiGx43k2EdyE2c8W5zNgN20DgBNjZUy1a6ZxeRUMXgcKP4RPYcr7 bXQszPUlZXkt/PWSrLwCrswjlZFPXTKc+gdiisL1WwAZ0ij8tO3XabgQuDk///za /hGQ= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:Received:Received:Received:Received:Received:To:Subject:Message-Id:Date:From:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=aOcVbkapt4/rkkKb/MkRr8qpOPFByQtsAOsJN4rQNq5pc2Om0Mp7M3vPtS6RzX JxLfDBFvQoJsZnen+a0UFqFGyag29ZqUPKpKfIuw8pVk33SwTfDIJrmi9ylikhnl 7uPNKAEI5riMhTkilRziSrgX4b51dpln4izK3+bJQHgRo=; Received: (qmail 11745 invoked by alias); 24 Sep 2012 21:41:53 -0000 Received: (qmail 11737 invoked by uid 22791); 24 Sep 2012 21:41:53 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD, URIBL_DBL_REDIR X-Spam-Check-By: sourceware.org Received: from mail-vb0-f73.google.com (HELO mail-vb0-f73.google.com) (209.85.212.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Sep 2012 21:41:40 +0000 Received: by vbbfs19 with SMTP id fs19so830560vbb.2 for ; Mon, 24 Sep 2012 14:41:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=to:subject:message-id:date:from:x-gm-message-state; bh=U5Ebe2dsjbSglu5WjUOAoXLdkIjTy4R4HzYkH80EGgQ=; b=fXsWrHzrW4bgFQvREtqNolWn6T2+jOT5PQ6oX47zxC6HlDSFwnPoHz+Wn29AYq8pEi Fa0ssxuAySg6KO4s2TOw8s7KhiiGECmBhr1wL81KVWHWV5NWbPICngd/7sMz18i3Yz9T vtMYaFmteXF3rEpptH7IqePkts3H4DASI5ZPo9wH/PxLtGI5X25qQHIHpC1p2RWoMxoc 31B6r3OIQvgSAj5eipR9BlRi2V2/DsWLeRlY/UYTDfqlv3tZwYv3N5eVHMFYG7tu9YFH npmPy3Op26gJRkFngm49zA5aZO/nV65ZeB2Sh4cJ0l8iEBsgVbE/Ve+fiMaxDzjFmfPv zDcg== Received: by 10.236.84.225 with SMTP id s61mr2671648yhe.11.1348522899531; Mon, 24 Sep 2012 14:41:39 -0700 (PDT) Received: by 10.236.84.225 with SMTP id s61mr2671641yhe.11.1348522899469; Mon, 24 Sep 2012 14:41:39 -0700 (PDT) Received: from wpzn3.hot.corp.google.com (216-239-44-65.google.com [216.239.44.65]) by gmr-mx.google.com with ESMTPS id u17si263337ank.0.2012.09.24.14.41.39 (version=TLSv1/SSLv3 cipher=AES128-SHA); Mon, 24 Sep 2012 14:41:39 -0700 (PDT) Received: from rong2.dls.corp.google.com (rong2.dls.corp.google.com [172.25.4.203]) by wpzn3.hot.corp.google.com (Postfix) with ESMTP id 43C6E100052; Mon, 24 Sep 2012 14:41:39 -0700 (PDT) Received: by rong2.dls.corp.google.com (Postfix, from userid 104659) id B0D4B55CAC; Mon, 24 Sep 2012 14:41:38 -0700 (PDT) To: reply@codereview.appspotmail.com, davidxl@google.com, gcc-patches@gcc.gnu.org Subject: [google 4.7] not group modules with -frtti and -fno-rtti (issue6569045) Message-Id: <20120924214138.B0D4B55CAC@rong2.dls.corp.google.com> Date: Mon, 24 Sep 2012 14:41:38 -0700 (PDT) From: xur@google.com (Rong Xu) X-Gm-Message-State: ALoCoQnKrJeLso2myJufM4suYXU41hwa9S106p1T+4pAldXdrPNsmB2blWpxk/uCV+/ZitAzWcBCBJCsioeKpIYbgidQSdtPGFn3ZAZT71zZ4SC9SM4EAnUB6DKW/sZmGFupQpJME9AvPWfyXV7cf8ApcxFbzjVFRd5x4RwSwRcr/fCKlWKcozBuTAaCXd+Kax8PLwJRX4m5 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi, This patch is for google branches only. It prohibits the grouping of modules with diffent flag_rtti value. otherwise it may cause profile mismatch, undefined symbols and some other internal errors. Tested with google internal benchmarks. Thanks, -Rong 2012-09-24 Rong Xu * gcc/coverage.c (force_matching_cg_opts): add new entries. Google Ref: b/7210837 and b/7210303. --- This patch is available for review at http://codereview.appspot.com/6569045 Index: gcc/coverage.c =================================================================== --- gcc/coverage.c (revision 191679) +++ gcc/coverage.c (working copy) @@ -274,6 +274,7 @@ { { "-fexceptions", "-fno-exceptions", true }, { "-fsized-delete", "-fno-sized-delete", false }, + { "-frtti", "-fno-rtti", true }, { NULL, NULL, false } };