Patchwork [google,4.7] not group modules with -frtti and -fno-rtti (issue6569045)

login
register
mail settings
Submitter Rong Xu
Date Sept. 24, 2012, 9:41 p.m.
Message ID <20120924214138.B0D4B55CAC@rong2.dls.corp.google.com>
Download mbox | patch
Permalink /patch/186579/
State New
Headers show

Comments

Rong Xu - Sept. 24, 2012, 9:41 p.m.
Hi,

This patch is for google branches only.
It prohibits the grouping of modules with diffent flag_rtti value.
otherwise it may cause profile mismatch, undefined symbols and some other
internal errors.

Tested with google internal benchmarks.

Thanks,

-Rong


2012-09-24  Rong Xu  <xur@google.com>

	* gcc/coverage.c (force_matching_cg_opts): add new entries.
        Google Ref: b/7210837 and b/7210303. 


--
This patch is available for review at http://codereview.appspot.com/6569045
Xinliang David Li - Sept. 24, 2012, 9:48 p.m.
Ok.

David

On Mon, Sep 24, 2012 at 2:41 PM, Rong Xu <xur@google.com> wrote:
> Hi,
>
> This patch is for google branches only.
> It prohibits the grouping of modules with diffent flag_rtti value.
> otherwise it may cause profile mismatch, undefined symbols and some other
> internal errors.
>
> Tested with google internal benchmarks.
>
> Thanks,
>
> -Rong
>
>
> 2012-09-24  Rong Xu  <xur@google.com>
>
>         * gcc/coverage.c (force_matching_cg_opts): add new entries.
>         Google Ref: b/7210837 and b/7210303.
>
> Index: gcc/coverage.c
> ===================================================================
> --- gcc/coverage.c      (revision 191679)
> +++ gcc/coverage.c      (working copy)
> @@ -274,6 +274,7 @@
>    {
>      { "-fexceptions", "-fno-exceptions", true },
>      { "-fsized-delete", "-fno-sized-delete", false },
> +    { "-frtti", "-fno-rtti", true },
>      { NULL, NULL, false }
>    };
>
>
> --
> This patch is available for review at http://codereview.appspot.com/6569045

Patch

Index: gcc/coverage.c
===================================================================
--- gcc/coverage.c	(revision 191679)
+++ gcc/coverage.c	(working copy)
@@ -274,6 +274,7 @@ 
   {
     { "-fexceptions", "-fno-exceptions", true },
     { "-fsized-delete", "-fno-sized-delete", false },
+    { "-frtti", "-fno-rtti", true },
     { NULL, NULL, false }
   };