Patchwork external-toolchain: BR2_TOOLCHAIN_EXTERNAL_GLIBC includes eglibc

login
register
mail settings
Submitter Baruch Siach
Date Sept. 24, 2012, 7:38 p.m.
Message ID <1348515532-4855-1-git-send-email-baruch@tkos.co.il>
Download mbox | patch
Permalink /patch/186558/
State Superseded
Headers show

Comments

Baruch Siach - Sept. 24, 2012, 7:38 p.m.
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 toolchain/toolchain-external/Config.in |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Yann E. MORIN - Sept. 24, 2012, 8:26 p.m.
Baruch, All,

On Monday 24 September 2012 21:38:52 Baruch Siach wrote:
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  toolchain/toolchain-external/Config.in |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/toolchain/toolchain-external/Config.in b/toolchain/toolchain-external/Config.in
> index f86ed74..911fea4 100644
> --- a/toolchain/toolchain-external/Config.in
> +++ b/toolchain/toolchain-external/Config.in
> @@ -664,7 +664,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC
>  	select BR2_TOOLCHAIN_HAS_SHADOW_PASSWORDS
>  
>  config BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC
> -	bool "glibc"
> +	bool "glibc/eglibc"
>  	select BR2_TOOLCHAIN_EXTERNAL_GLIBC

For all practical purposes, that's true.

Although eglibc can be configured to include/exclude parts of the features,
it seems to not be in wide use, if at all.

So, I'd like that to be at least mentionned in the commit log, and maybe
as a help entry for BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC.

With that:
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

Patch

diff --git a/toolchain/toolchain-external/Config.in b/toolchain/toolchain-external/Config.in
index f86ed74..911fea4 100644
--- a/toolchain/toolchain-external/Config.in
+++ b/toolchain/toolchain-external/Config.in
@@ -664,7 +664,7 @@  config BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC
 	select BR2_TOOLCHAIN_HAS_SHADOW_PASSWORDS
 
 config BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC
-	bool "glibc"
+	bool "glibc/eglibc"
 	select BR2_TOOLCHAIN_EXTERNAL_GLIBC
 
 endchoice