From patchwork Mon Sep 24 12:23:52 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Monakhov X-Patchwork-Id: 186388 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6C9752C007D for ; Mon, 24 Sep 2012 22:24:08 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754555Ab2IXMYF (ORCPT ); Mon, 24 Sep 2012 08:24:05 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:50631 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754475Ab2IXMYD (ORCPT ); Mon, 24 Sep 2012 08:24:03 -0400 Received: by mail-lb0-f174.google.com with SMTP id gj3so6602143lbb.19 for ; Mon, 24 Sep 2012 05:24:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=qizX8g9WMQBB3IeV0alhMEqh5MRjRpNF4dvsW1R7nik=; b=uH/W35kl4yvJ8XJT+JEoyBvsvTikafLBYk8GmvFutR4x0PJccWldWN1bYCQC5xUgFR v43c0fXADu2sV6/8dn4YpyFi5tjvkhvOcA5P/XgeOn8Rf6Ii8M3crpOCevbXaeAVSZRn IA3MoUnzS99drCQph2XJDDYJkQkJhK2zOAjikrHeyxqwswoi1+ezRJhO4QWYIp/yWxxO /7G7SVq9AzAFl6+Bc0dg36upCCRnBBlifJI4sJmVu9N38VNStJyMa6dnGwbuI4tR39G6 OvvVgbLVrpNeg3HKKcr+r9+Sk4kxNmvb3AyEmebAIsWtmU/H3r8a8yiSm9/JcZK87i1l dIyw== Received: by 10.112.99.4 with SMTP id em4mr2416853lbb.62.1348489442906; Mon, 24 Sep 2012 05:24:02 -0700 (PDT) Received: from smtp.gmail.com (swsoft-msk-nat.sw.ru. [195.214.232.10]) by mx.google.com with ESMTPS id d1sm4252705lbk.16.2012.09.24.05.24.02 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 24 Sep 2012 05:24:02 -0700 (PDT) From: Dmitry Monakhov To: linux-ext4@vger.kernel.org Cc: tytso@mit.edu, a-fujita@rs.jp.nec.com, Dmitry Monakhov Subject: [PATCH 2/4] ext4: online defrag is not supported for journaled files Date: Mon, 24 Sep 2012 16:23:52 +0400 Message-Id: <1348489434-22778-3-git-send-email-dmonakhov@openvz.org> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <1348489434-22778-1-git-send-email-dmonakhov@openvz.org> References: <1348489434-22778-1-git-send-email-dmonakhov@openvz.org> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Proper block swap for inodes with full journaling enabled is truly non obvious task. In order to be on a safe side let's explicitly disable it for now. Signed-off-by: Dmitry Monakhov --- fs/ext4/move_extent.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index 37c8497..0aa2ad7 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c @@ -1142,7 +1142,12 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, orig_inode->i_ino, donor_inode->i_ino); return -EINVAL; } - + /* TODO: This is non obvious task to swap blocks for inodes with full + jornaling enabled */ + if (ext4_should_journal_data(orig_inode) || + ext4_should_journal_data(donor_inode)) { + return -EINVAL; + } /* Protect orig and donor inodes against a truncate */ mext_inode_double_lock(orig_inode, donor_inode);