From patchwork Mon Sep 24 11:44:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Monakhov X-Patchwork-Id: 186375 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 425542C0086 for ; Mon, 24 Sep 2012 21:44:34 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754680Ab2IXLoc (ORCPT ); Mon, 24 Sep 2012 07:44:32 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:54781 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752250Ab2IXLob (ORCPT ); Mon, 24 Sep 2012 07:44:31 -0400 Received: by lbbgj3 with SMTP id gj3so6549370lbb.19 for ; Mon, 24 Sep 2012 04:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=D0I1A4anN8Y+HqU14x5f8iExKWOP8/O1Ut/u+glQlf0=; b=n5Eb+5XODF5kedEjSfzKnIjGx2xQ7ooNikCr0i3y/yRCE2LDAx07WryZoXkYAWHoev xzg48EUu/TudmNW9ScL7Y7DkScxVI/0CJilQNBMBu+N8Dyb8zr0T53NkwNAvWwS5Sbz9 IMNBzkL0x0Mrk0RN/BT02DmkyOJjQsDsJt4jBtHbDSk3GTQcXnzaZwh6EwDIhd76s05C 1Q+hsrGCRly8zanuGNns1waarfN91z7szpNWTO7EOPkS4loDDPHu/NXb5DaE7c1nEvzH wS9t0An871yKciP0dzAxR5Wf4x20myIdZuUijjPzml94Il66eJroVYmsUdpjPqztmDNa ZJhw== Received: by 10.112.86.102 with SMTP id o6mr4082679lbz.113.1348487069745; Mon, 24 Sep 2012 04:44:29 -0700 (PDT) Received: from smtp.gmail.com (swsoft-msk-nat.sw.ru. [195.214.232.10]) by mx.google.com with ESMTPS id o7sm4237109lbg.4.2012.09.24.04.44.28 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 24 Sep 2012 04:44:29 -0700 (PDT) From: Dmitry Monakhov To: linux-ext4@vger.kernel.org Cc: tytso@mit.edu, jack@suse.cz, lczerner@redhat.com, Dmitry Monakhov Subject: [PATCH 01/10] ext4: ext4_inode_info diet Date: Mon, 24 Sep 2012 15:44:11 +0400 Message-Id: <1348487060-19598-2-git-send-email-dmonakhov@openvz.org> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <1348487060-19598-1-git-send-email-dmonakhov@openvz.org> References: <1348487060-19598-1-git-send-email-dmonakhov@openvz.org> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Generic inode has unused i_private pointer which may be used as cur_aio_dio storage. TODO: If cur_aio_dio will be passed as an argument to get_block_t this allow to have concurent AIO_DIO requests. Reviewed-by: Zheng Liu Signed-off-by: Dmitry Monakhov --- fs/ext4/ext4.h | 5 +++-- fs/ext4/extents.c | 4 ++-- fs/ext4/inode.c | 6 +++--- fs/ext4/super.c | 1 - 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index 8b6902c..e59fbc5 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -912,8 +912,6 @@ struct ext4_inode_info { struct list_head i_completed_io_list; spinlock_t i_completed_io_lock; atomic_t i_ioend_count; /* Number of outstanding io_end structs */ - /* current io_end structure for async DIO write*/ - ext4_io_end_t *cur_aio_dio; atomic_t i_aiodio_unwritten; /* Nr. of inflight conversions pending */ spinlock_t i_block_reservation_lock; @@ -929,6 +927,9 @@ struct ext4_inode_info { __u32 i_csum_seed; }; +/* current io_end structure for async DIO write */ +#define EXT4_CUR_AIO_DIO(inode) (inode)->i_private + /* * File system states */ diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index cc6d2b9..6eb6b0c 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -3645,7 +3645,7 @@ ext4_ext_handle_uninitialized_extents(handle_t *handle, struct inode *inode, { int ret = 0; int err = 0; - ext4_io_end_t *io = EXT4_I(inode)->cur_aio_dio; + ext4_io_end_t *io = (ext4_io_end_t*) EXT4_CUR_AIO_DIO(inode); ext_debug("ext4_ext_handle_uninitialized_extents: inode %lu, logical " "block %llu, max_blocks %u, flags %x, allocated %u\n", @@ -3903,7 +3903,7 @@ int ext4_ext_map_blocks(handle_t *handle, struct inode *inode, unsigned int allocated = 0, offset = 0; unsigned int allocated_clusters = 0; struct ext4_allocation_request ar; - ext4_io_end_t *io = EXT4_I(inode)->cur_aio_dio; + ext4_io_end_t *io = (ext4_io_end_t*) EXT4_CUR_AIO_DIO(inode); ext4_lblk_t cluster_offset; ext_debug("blocks %u/%u requested for inode %lu\n", diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 462f4b3..05206ba 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -3057,7 +3057,7 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb, * hook to the iocb. */ iocb->private = NULL; - EXT4_I(inode)->cur_aio_dio = NULL; + EXT4_CUR_AIO_DIO(inode) = NULL; if (!is_sync_kiocb(iocb)) { ext4_io_end_t *io_end = ext4_init_io_end(inode, GFP_NOFS); @@ -3074,7 +3074,7 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb, * is a unwritten extents needs to be converted * when IO is completed. */ - EXT4_I(inode)->cur_aio_dio = iocb->private; + EXT4_CUR_AIO_DIO(inode) = iocb->private; } if (overwrite) @@ -3094,7 +3094,7 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb, NULL, DIO_LOCKING); if (iocb->private) - EXT4_I(inode)->cur_aio_dio = NULL; + EXT4_CUR_AIO_DIO(inode) = NULL; /* * The io_end structure takes a reference to the inode, * that structure needs to be destroyed and the diff --git a/fs/ext4/super.c b/fs/ext4/super.c index eb7722a..64acf55 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -965,7 +965,6 @@ static struct inode *ext4_alloc_inode(struct super_block *sb) ei->jinode = NULL; INIT_LIST_HEAD(&ei->i_completed_io_list); spin_lock_init(&ei->i_completed_io_lock); - ei->cur_aio_dio = NULL; ei->i_sync_tid = 0; ei->i_datasync_tid = 0; atomic_set(&ei->i_ioend_count, 0);