From patchwork Sun Sep 23 16:33:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Blue Swirl X-Patchwork-Id: 186247 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 653522C009E for ; Mon, 24 Sep 2012 02:33:51 +1000 (EST) Received: from localhost ([::1]:35797 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFp7t-0007CK-Gx for incoming@patchwork.ozlabs.org; Sun, 23 Sep 2012 12:33:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFp7l-0007C4-QN for qemu-devel@nongnu.org; Sun, 23 Sep 2012 12:33:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFp7k-0001iR-RG for qemu-devel@nongnu.org; Sun, 23 Sep 2012 12:33:41 -0400 Received: from mail-ee0-f45.google.com ([74.125.83.45]:64233) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFp7k-0001iN-Kq for qemu-devel@nongnu.org; Sun, 23 Sep 2012 12:33:40 -0400 Received: by eekb47 with SMTP id b47so191949eek.4 for ; Sun, 23 Sep 2012 09:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=xkZZK7EvZSJuOUb8oFyMgLUojhXo2kZJLBgfNtLRVWU=; b=cEvktkP8dWDpeA1UhJS4XWRUlKOon/OiAcPfwx+fQ9VJl9QqJqY9dkc8QOAbdR4T/u Aq6b5KnQ1cBfdzo6sksrtvI8hXmaRO/tm4v0oxst3NxfA+a3ScwbpXwgGIiCW3/N/U52 qJ57Fwb+mMF58WOlbYp3kQSMnbCYkenUgqHv0zgEf+czjFXGujqelkscXOgup3EW0S01 u38kRDmwQJbMXBQBokb87tF5nZEcfKBZGSc02W91Iepr1o7643OWI3N7NIP15uKFLFLa KiN7NBjGtMHkQV8VcKBqWfIxH5zfNeI8XW4ynsvGbh7L7fanUBk7y1wcQT9xrBV8P7XT R+Ig== Received: by 10.14.4.201 with SMTP id 49mr12201113eej.0.1348418019792; Sun, 23 Sep 2012 09:33:39 -0700 (PDT) Received: from localhost.localdomain ([2001:5c0:1115:ba00:b093:d236:9a0a:8d3c]) by mx.google.com with ESMTPS id m42sm36983519eep.16.2012.09.23.09.33.37 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 23 Sep 2012 09:33:39 -0700 (PDT) From: Blue Swirl To: qemu-devel@nongnu.org Date: Sun, 23 Sep 2012 16:33:31 +0000 Message-Id: <23216f8d6e3e00bdf667e1c7f942500d3c892a18.1348417996.git.blauwirbel@gmail.com> X-Mailer: git-send-email 1.7.2.5 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.83.45 Cc: blauwirbel@gmail.com Subject: [Qemu-devel] [PATCH] gic: avoid a warning from clang X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Avoid this warning: CC arm-softmmu/hw/arm/../arm_gic.o /src/qemu/hw/arm/../arm_gic.c:432:17: error: implicit truncation from 'unsigned int' to bitfield changes value from 4294967040 to 0 [-Werror,-Wconstant-conversion] GIC_CLEAR_PENDING(irq + i, ALL_CPU_MASK); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /src/qemu/hw/arm/../arm_gic_internal.h:43:62: note: expanded from: #define GIC_CLEAR_PENDING(irq, cm) s->irq_state[irq].pending &= ~(cm) ^ ~~~~~ 4294967040 is 0xffffff00 and field 'pending' is effectively 8 bits wide, so the masking has no effect except for avoiding the warning. Signed-off-by: Blue Swirl --- hw/arm_gic_internal.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/arm_gic_internal.h b/hw/arm_gic_internal.h index db4fad5..219aef3 100644 --- a/hw/arm_gic_internal.h +++ b/hw/arm_gic_internal.h @@ -40,7 +40,8 @@ #define GIC_CLEAR_ENABLED(irq, cm) s->irq_state[irq].enabled &= ~(cm) #define GIC_TEST_ENABLED(irq, cm) ((s->irq_state[irq].enabled & (cm)) != 0) #define GIC_SET_PENDING(irq, cm) s->irq_state[irq].pending |= (cm) -#define GIC_CLEAR_PENDING(irq, cm) s->irq_state[irq].pending &= ~(cm) +#define GIC_CLEAR_PENDING(irq, cm) \ + s->irq_state[irq].pending &= ~(cm) & ALL_CPU_MASK #define GIC_TEST_PENDING(irq, cm) ((s->irq_state[irq].pending & (cm)) != 0) #define GIC_SET_ACTIVE(irq, cm) s->irq_state[irq].active |= (cm) #define GIC_CLEAR_ACTIVE(irq, cm) s->irq_state[irq].active &= ~(cm)