From patchwork Sun Sep 23 10:00:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 186197 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B97332C0092 for ; Sun, 23 Sep 2012 20:20:24 +1000 (EST) Received: from localhost ([::1]:46614 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFizy-0005ZB-BN for incoming@patchwork.ozlabs.org; Sun, 23 Sep 2012 06:01:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFizK-0003ju-5f for qemu-devel@nongnu.org; Sun, 23 Sep 2012 06:00:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFizJ-0007c7-74 for qemu-devel@nongnu.org; Sun, 23 Sep 2012 06:00:34 -0400 Received: from mail-we0-f173.google.com ([74.125.82.173]:56749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFizI-0007Xh-Vc for qemu-devel@nongnu.org; Sun, 23 Sep 2012 06:00:33 -0400 Received: by mail-we0-f173.google.com with SMTP id t11so2574474wey.4 for ; Sun, 23 Sep 2012 03:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=V1nfW//0ETHBwvApNaJ2ZPVKU7Nk/B/BdRsDiYa1j3U=; b=ixfFpBWByzXrtvJAsKe1UdBohG4aJhrL/7Cj1b6mM8my5BJ71euvOUDO5st/vDXX9b 8sMUcDkLOh3QHFPds0F9y4BLZRSzADB1HE99qYwF7362AJm1fHjL2Ck68wEf9KWNVwE4 Q59y2Q1Q84biENyjElTYNWBC069ngwjDU2IfA6dEqKZqwr8eALO2dywgJ8qxNO/D+ivV GEODim6TtTHobWCuUl54ZFlSx7HHV1IG0x11frjTRsC25UYfNb0K5ZgZYQzXhrvWIVmy h/MwJog2RG2hiXwfYzXBf321k3eJVn2B2hAoHi53z0TLYqsrXMkus7p4OLgQPoAWdXfw wRnw== Received: by 10.180.106.130 with SMTP id gu2mr7571382wib.20.1348394432529; Sun, 23 Sep 2012 03:00:32 -0700 (PDT) Received: from localhost ([109.224.133.37]) by mx.google.com with ESMTPS id fr4sm9490148wib.8.2012.09.23.03.00.31 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 23 Sep 2012 03:00:32 -0700 (PDT) From: Stefan Hajnoczi To: Anthony Liguori Date: Sun, 23 Sep 2012 11:00:09 +0100 Message-Id: <1348394420-28298-4-git-send-email-stefanha@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1348394420-28298-1-git-send-email-stefanha@gmail.com> References: <1348394420-28298-1-git-send-email-stefanha@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.173 Cc: Stefan Weil , qemu-devel@nongnu.org, Stefan Hajnoczi Subject: [Qemu-devel] [PATCH 03/14] qemu-sockets: Fix potential memory leak X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Stefan Weil The old code leaks variable 'peer'. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- qemu-sockets.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-sockets.c b/qemu-sockets.c index 361d890..037775b 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -353,7 +353,7 @@ int inet_dgram_opts(QemuOpts *opts) if (0 != (rc = getaddrinfo(addr, port, &ai, &local))) { fprintf(stderr,"getaddrinfo(%s,%s): %s\n", addr, port, gai_strerror(rc)); - return -1; + goto err; } /* create socket */