From patchwork Sun Sep 23 10:00:16 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [10/14] TextConsole: saturate escape parameter in TTY_STATE_CSI Date: Sun, 23 Sep 2012 00:00:16 -0000 From: Stefan Hajnoczi X-Patchwork-Id: 186196 Message-Id: <1348394420-28298-11-git-send-email-stefanha@gmail.com> To: Anthony Liguori Cc: Stefan Hajnoczi , Laszlo Ersek , qemu-devel@nongnu.org From: Laszlo Ersek Signed-off-by: Laszlo Ersek Reviewed-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- console.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/console.c b/console.c index a8bcc42..3f3d254 100644 --- a/console.c +++ b/console.c @@ -938,8 +938,11 @@ static void console_putchar(TextConsole *s, int ch) case TTY_STATE_CSI: /* handle escape sequence parameters */ if (ch >= '0' && ch <= '9') { if (s->nb_esc_params < MAX_ESC_PARAMS) { - s->esc_params[s->nb_esc_params] = - s->esc_params[s->nb_esc_params] * 10 + ch - '0'; + int *param = &s->esc_params[s->nb_esc_params]; + int digit = (ch - '0'); + + *param = (*param <= (INT_MAX - digit) / 10) ? + *param * 10 + digit : INT_MAX; } } else { if (s->nb_esc_params < MAX_ESC_PARAMS)