From patchwork Sun Sep 23 10:00:08 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 186190 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3CAE72C0093 for ; Sun, 23 Sep 2012 20:00:56 +1000 (EST) Received: from localhost ([::1]:43900 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFize-00044V-Be for incoming@patchwork.ozlabs.org; Sun, 23 Sep 2012 06:00:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFizK-0003l8-Hg for qemu-devel@nongnu.org; Sun, 23 Sep 2012 06:00:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFizH-0007ah-TB for qemu-devel@nongnu.org; Sun, 23 Sep 2012 06:00:34 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:39659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFizH-0007aL-M2 for qemu-devel@nongnu.org; Sun, 23 Sep 2012 06:00:31 -0400 Received: by wgbdr1 with SMTP id dr1so3090777wgb.10 for ; Sun, 23 Sep 2012 03:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=eWC2KQR+aspbZGVih+2Nu06cddwCX2lrvebNz72G6wo=; b=hAGEmvv4CEYzlIql4NDE4HyR49+5LnUyGScxwnhlOus6GLih5LkkdZRY5AvYxnOn8m XqnjOhGvGNkeBGS41YgI3glSPfnBlQd3l6ClKu2PkR4hRdLsEfQoQ4uT+KE9unvuZIVr FxrxksLmCtsv+HWlqJ9mwVSyDo5CjF3Tn7zokUDR6M0mFY63CHIwWD9rzVnGzLl+SeVJ JcfuVR01C2bGZa+hOgBFSdq7AHq2rKXYHudHaVbZupPNE3UvJOumxbmAXHwDSxvYxWbt jHV0FghjHQkDzK11BnCvoI01RqIYougzu45U3ecvq73aAwtgibGkIDxz+f53aD749pBW /jqw== Received: by 10.216.29.17 with SMTP id h17mr5483308wea.221.1348394430807; Sun, 23 Sep 2012 03:00:30 -0700 (PDT) Received: from localhost ([109.224.133.37]) by mx.google.com with ESMTPS id dm3sm9498091wib.3.2012.09.23.03.00.29 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 23 Sep 2012 03:00:30 -0700 (PDT) From: Stefan Hajnoczi To: Anthony Liguori Date: Sun, 23 Sep 2012 11:00:08 +0100 Message-Id: <1348394420-28298-3-git-send-email-stefanha@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1348394420-28298-1-git-send-email-stefanha@gmail.com> References: <1348394420-28298-1-git-send-email-stefanha@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.53 Cc: Stefan Weil , qemu-devel@nongnu.org, Stefan Hajnoczi Subject: [Qemu-devel] [PATCH 02/14] qemu-ga: Remove unreachable code after g_error X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Stefan Weil Report from smatch: qemu-ga.c:117 register_signal_handlers(11) info: ignoring unreachable code. qemu-ga.c:122 register_signal_handlers(16) info: ignoring unreachable code. g_error calls abort which terminates the program. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- qemu-ga.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/qemu-ga.c b/qemu-ga.c index 7623079..b747470 100644 --- a/qemu-ga.c +++ b/qemu-ga.c @@ -114,12 +114,10 @@ static gboolean register_signal_handlers(void) ret = sigaction(SIGINT, &sigact, NULL); if (ret == -1) { g_error("error configuring signal handler: %s", strerror(errno)); - return false; } ret = sigaction(SIGTERM, &sigact, NULL); if (ret == -1) { g_error("error configuring signal handler: %s", strerror(errno)); - return false; } return true;