From patchwork Sat Sep 22 11:53:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Glisse X-Patchwork-Id: 186128 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 21B452C0094 for ; Sat, 22 Sep 2012 21:54:16 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1348919657; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Date:From:To:cc:Subject:Message-ID:User-Agent:MIME-Version: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=YCrvD9Z 7BEsU5cwmZWG8AJZMP5w=; b=BH9S2mf5YaQGDJf+eBQ15YqUhmpQF1D86ffqfuX CygK8C+hfWqIXuyfa9Tbd6NXOgYnvhTF1vkLW2RpedE/xaoZKnACud3gJ7e2/kSE IocGKxXoLdUDJX3UhD1GDnCRxILVjnSwnH31yh7qUDLqvArchm0xtBAHod0zAXNj 1y+8= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Date:From:To:cc:Subject:Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=yIk7PB2x3yL0MWL2gYIL8TheAbvg1QC9geAYi9w00SJ8zcABOntDnY/ZBrqKKP WHxZp6i1k+t2UQholffJPl4Lyv1JOKJr18sOhWHGCEbd4V2LH4RhQtJKl6mnKRiE eIIkao4UNrhBlOH2p5eLMP3Z0AlGhC+PROist+Gm6OTCg=; Received: (qmail 418 invoked by alias); 22 Sep 2012 11:54:13 -0000 Received: (qmail 408 invoked by uid 22791); 22 Sep 2012 11:54:12 -0000 X-SWARE-Spam-Status: No, hits=-7.1 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail4-relais-sop.national.inria.fr (HELO mail4-relais-sop.national.inria.fr) (192.134.164.105) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 22 Sep 2012 11:53:35 +0000 Received: from stedding.saclay.inria.fr ([193.55.250.194]) by mail4-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES128-SHA; 22 Sep 2012 13:53:33 +0200 Received: from glisse (helo=localhost) by stedding.saclay.inria.fr with local-esmtp (Exim 4.80) (envelope-from ) id 1TFOH7-0005D2-1N; Sat, 22 Sep 2012 13:53:33 +0200 Date: Sat, 22 Sep 2012 13:53:32 +0200 (CEST) From: Marc Glisse To: gcc-patches@gcc.gnu.org cc: rth@redhat.com Subject: Remove duplicated block of code Message-ID: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hello, this patch removes one copy of a block of code that somehow ended up duplicated. Richard Henderson apparently already fixed part of the problem here: http://gcc.gnu.org/ml/gcc-patches/2011-10/msg00120.html but missed this bit (or was it a different patch?). Not yet tested (seems obvious enough), but I'll still do it after I get an ok. 2012-09-24 Marc Glisse * expr.c (do_store_flag): Remove duplicated code. Index: expr.c =================================================================== --- expr.c (revision 191640) +++ expr.c (working copy) @@ -10679,33 +10679,22 @@ do_store_flag (sepops ops, rtx target, e /* For vector typed comparisons emit code to generate the desired all-ones or all-zeros mask. Conveniently use the VEC_COND_EXPR expander for this. */ if (TREE_CODE (ops->type) == VECTOR_TYPE) { tree ifexp = build2 (ops->code, ops->type, arg0, arg1); tree if_true = constant_boolean_node (true, ops->type); tree if_false = constant_boolean_node (false, ops->type); return expand_vec_cond_expr (ops->type, ifexp, if_true, if_false, target); } - /* For vector typed comparisons emit code to generate the desired - all-ones or all-zeros mask. Conveniently use the VEC_COND_EXPR - expander for this. */ - if (TREE_CODE (ops->type) == VECTOR_TYPE) - { - tree ifexp = build2 (ops->code, ops->type, arg0, arg1); - tree if_true = constant_boolean_node (true, ops->type); - tree if_false = constant_boolean_node (false, ops->type); - return expand_vec_cond_expr (ops->type, ifexp, if_true, if_false, target); - } - /* Get the rtx comparison code to use. We know that EXP is a comparison operation of some type. Some comparisons against 1 and -1 can be converted to comparisons with zero. Do so here so that the tests below will be aware that we have a comparison with zero. These tests will not catch constants in the first operand, but constants are rarely passed as the first operand. */ switch (ops->code) { case EQ_EXPR: code = EQ;