Patchwork mtd: onenand: Make flexonenand_set_boundary static

login
register
mail settings
Submitter Sachin Kamat
Date Sept. 22, 2012, 6:12 a.m.
Message ID <1348294351-27182-1-git-send-email-sachin.kamat@linaro.org>
Download mbox | patch
Permalink /patch/186097/
State New
Headers show

Comments

Sachin Kamat - Sept. 22, 2012, 6:12 a.m.
Fixes the following sparse warning:
drivers/mtd/onenand/onenand_base.c:3697:5: warning:
symbol 'flexonenand_set_boundary' was not declared. Should it be static?

Cc: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/mtd/onenand/onenand_base.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Kyungmin Park - Sept. 22, 2012, 6:40 a.m.
On 9/22/12, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Fixes the following sparse warning:
> drivers/mtd/onenand/onenand_base.c:3697:5: warning:
> symbol 'flexonenand_set_boundary' was not declared. Should it be static?
>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/mtd/onenand/onenand_base.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/onenand/onenand_base.c
> b/drivers/mtd/onenand/onenand_base.c
> index 7153e0d..b3f41f2 100644
> --- a/drivers/mtd/onenand/onenand_base.c
> +++ b/drivers/mtd/onenand/onenand_base.c
> @@ -3694,7 +3694,7 @@ static int flexonenand_check_blocks_erased(struct
> mtd_info *mtd, int start, int
>   * flexonenand_set_boundary	- Writes the SLC boundary
>   * @param mtd			- mtd info structure
>   */
> -int flexonenand_set_boundary(struct mtd_info *mtd, int die,
> +static int flexonenand_set_boundary(struct mtd_info *mtd, int die,
>  				    int boundary, int lock)
>  {
>  	struct onenand_chip *this = mtd->priv;
> --
> 1.7.4.1
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
Sachin Kamat - Oct. 1, 2012, 6:10 p.m.
Hi David,

Please line up this patch for 3.7.

On 22 September 2012 12:10, Kyungmin Park <kyungmin.park@samsung.com> wrote:
> On 9/22/12, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> Fixes the following sparse warning:
>> drivers/mtd/onenand/onenand_base.c:3697:5: warning:
>> symbol 'flexonenand_set_boundary' was not declared. Should it be static?
>>
>> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>>  drivers/mtd/onenand/onenand_base.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mtd/onenand/onenand_base.c
>> b/drivers/mtd/onenand/onenand_base.c
>> index 7153e0d..b3f41f2 100644
>> --- a/drivers/mtd/onenand/onenand_base.c
>> +++ b/drivers/mtd/onenand/onenand_base.c
>> @@ -3694,7 +3694,7 @@ static int flexonenand_check_blocks_erased(struct
>> mtd_info *mtd, int start, int
>>   * flexonenand_set_boundary  - Writes the SLC boundary
>>   * @param mtd                        - mtd info structure
>>   */
>> -int flexonenand_set_boundary(struct mtd_info *mtd, int die,
>> +static int flexonenand_set_boundary(struct mtd_info *mtd, int die,
>>                                   int boundary, int lock)
>>  {
>>       struct onenand_chip *this = mtd->priv;
>> --
>> 1.7.4.1
>>
>>
>> ______________________________________________________
>> Linux MTD discussion mailing list
>> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>>
Artem Bityutskiy - Oct. 5, 2012, 9:32 a.m.
On Sat, 2012-09-22 at 11:42 +0530, Sachin Kamat wrote:
> Fixes the following sparse warning:
> drivers/mtd/onenand/onenand_base.c:3697:5: warning:
> symbol 'flexonenand_set_boundary' was not declared. Should it be static?
> 
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Pushed to l2-mtd.git, thanks!

Patch

diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index 7153e0d..b3f41f2 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -3694,7 +3694,7 @@  static int flexonenand_check_blocks_erased(struct mtd_info *mtd, int start, int
  * flexonenand_set_boundary	- Writes the SLC boundary
  * @param mtd			- mtd info structure
  */
-int flexonenand_set_boundary(struct mtd_info *mtd, int die,
+static int flexonenand_set_boundary(struct mtd_info *mtd, int die,
 				    int boundary, int lock)
 {
 	struct onenand_chip *this = mtd->priv;