| Message ID | 1348281858-24366-1-git-send-email-peterhuewe@gmx.de |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Peter Huewe <peterhuewe@gmx.de> Date: Sat, 22 Sep 2012 04:44:18 +0200 > Currently the driver has no MODULE_LICENSE attribute in its source which > results in a kernel taint if I load this: > > root@(none):~# modprobe bcm87xx > bcm87xx: module license 'unspecified' taints kernel. > > Since the first lines of the source code clearly state: > * This file is subject to the terms and conditions of the GNU General > * Public License. See the file "COPYING" in the main directory of this > * archive for more details. > I think it's safe to add the MODULE_LICENSE("GPL") macro and thus remove > the kernel taint. > > Cc: stable@vger.kernel.org > Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Good catch, applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/phy/bcm87xx.c b/drivers/net/phy/bcm87xx.c index 2346b38..7997895 100644 --- a/drivers/net/phy/bcm87xx.c +++ b/drivers/net/phy/bcm87xx.c @@ -229,3 +229,5 @@ static void __exit bcm87xx_exit(void) ARRAY_SIZE(bcm87xx_driver)); } module_exit(bcm87xx_exit); + +MODULE_LICENSE("GPL");
Currently the driver has no MODULE_LICENSE attribute in its source which results in a kernel taint if I load this: root@(none):~# modprobe bcm87xx bcm87xx: module license 'unspecified' taints kernel. Since the first lines of the source code clearly state: * This file is subject to the terms and conditions of the GNU General * Public License. See the file "COPYING" in the main directory of this * archive for more details. I think it's safe to add the MODULE_LICENSE("GPL") macro and thus remove the kernel taint. Cc: stable@vger.kernel.org Signed-off-by: Peter Huewe <peterhuewe@gmx.de> --- drivers/net/phy/bcm87xx.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)