Patchwork netlink: use <linux/export.h> instead of <linux/module.h>

login
register
mail settings
Submitter Pablo Neira
Date Sept. 21, 2012, 7:35 p.m.
Message ID <1348256138-15500-1-git-send-email-pablo@netfilter.org>
Download mbox | patch
Permalink /patch/185892/
State Accepted
Delegated to: David Miller
Headers show

Comments

Pablo Neira - Sept. 21, 2012, 7:35 p.m.
From: Pablo Neira Ayuso <pablo@netfilter.org>

Since (9f00d97 netlink: hide struct module parameter in netlink_kernel_create),
linux/netlink.h includes linux/module.h because of the use of THIS_MODULE.

Use linux/export.h instead, as suggested by Stephen Rothwell, which is
significantly smaller and defines THIS_MODULES.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 include/linux/netlink.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
David Miller - Sept. 21, 2012, 7:44 p.m.
From: pablo@netfilter.org
Date: Fri, 21 Sep 2012 21:35:38 +0200

> From: Pablo Neira Ayuso <pablo@netfilter.org>
> 
> Since (9f00d97 netlink: hide struct module parameter in netlink_kernel_create),
> linux/netlink.h includes linux/module.h because of the use of THIS_MODULE.
> 
> Use linux/export.h instead, as suggested by Stephen Rothwell, which is
> significantly smaller and defines THIS_MODULES.
> 
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

Applied, but please make explicit what tree you are targetting when you
submit changes like this in the future.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/include/linux/netlink.h b/include/linux/netlink.h
index 73ade5f..b3dc992 100644
--- a/include/linux/netlink.h
+++ b/include/linux/netlink.h
@@ -153,7 +153,7 @@  struct nlattr {
 
 #include <linux/capability.h>
 #include <linux/skbuff.h>
-#include <linux/module.h>
+#include <linux/export.h>
 #include <net/scm.h>
 
 struct net;