Patchwork [1/2] powerpc: Allow debugging of LMBs with lmb=debug

login
register
mail settings
Submitter Michael Ellerman
Date Jan. 15, 2009, 6:46 a.m.
Message ID <aab322f087db2ecc390ea5e224db143cf77d3067.1232001859.git.michael@ellerman.id.au>
Download mbox | patch
Permalink /patch/18585/
State Accepted, archived
Commit 059f134f844ec52772353c95693fcb5b86e80193
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Michael Ellerman - Jan. 15, 2009, 6:46 a.m.
The lmb debugging can be turned on at boottime with lmb=debug on the
command line. However on powerpc that doesn't work, because we don't
necessarily call lmb_dump_all().

So always call lmb_dump_all() after lmb_analyze(), no output is
generated unless lmb=debug is found on the command line.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
 arch/powerpc/kernel/prom.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)
David Miller - Jan. 15, 2009, 6:47 a.m.
From: Michael Ellerman <michael@ellerman.id.au>
Date: Thu, 15 Jan 2009 17:46:01 +1100 (EST)

> The lmb debugging can be turned on at boottime with lmb=debug on the
> command line. However on powerpc that doesn't work, because we don't
> necessarily call lmb_dump_all().
> 
> So always call lmb_dump_all() after lmb_analyze(), no output is
> generated unless lmb=debug is found on the command line.
> 
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>

Acked-by: David S. Miller <davem@davemloft.net>

Patch

diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
index c09cffa..045277b 100644
--- a/arch/powerpc/kernel/prom.c
+++ b/arch/powerpc/kernel/prom.c
@@ -1070,11 +1070,6 @@  static void __init early_reserve_mem(void)
 		DBG("reserving: %llx -> %llx\n", base, size);
 		lmb_reserve(base, size);
 	}
-
-#if 0
-	DBG("memory reserved, lmbs :\n");
-      	lmb_dump_all();
-#endif
 }
 
 #ifdef CONFIG_PHYP_DUMP
@@ -1216,6 +1211,7 @@  void __init early_init_devtree(void *params)
 	lmb_enforce_memory_limit(limit);
 
 	lmb_analyze();
+	lmb_dump_all();
 
 	DBG("Phys. mem: %lx\n", lmb_phys_mem_size());