Patchwork [7/7] SCSI: Standard INQUIRY data should report HiSup flag as set.

login
register
mail settings
Submitter Paolo Bonzini
Date Sept. 21, 2012, 2:52 p.m.
Message ID <1348239169-25040-8-git-send-email-pbonzini@redhat.com>
Download mbox | patch
Permalink /patch/185795/
State New
Headers show

Comments

Paolo Bonzini - Sept. 21, 2012, 2:52 p.m.
From: Ronnie Sahlberg <ronniesahlberg@gmail.com>

QEMU as far as I know only reports LUN numbers using the modes that
are described in SAM4.
As such, since all LUN numbers generated by the SCSI emulation in QEMU
follow SAM4, we should set the HiSup bit in the standard INQUIRY data
to indicate such.

From SAM4:
  4.6.3 LUNs overview
  All LUN formats described in this standard are hierarchical in
  structure even when only a single level in that hierarchy is used.
  The HISUP bit shall be set to one in the standard INQUIRY data
  (see SPC-4) when any LUN format described in this standard is used.
  Non-hierarchical formats are outside the scope of this standard.

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
---
 hw/scsi-disk.c | 2 +-
 1 file modificato, 1 inserzione(+). 1 rimozione(-)

Patch

diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 4ffca7a..95e9158 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -678,7 +678,7 @@  static int scsi_disk_emulate_inquiry(SCSIRequest *req, uint8_t *outbuf)
      * is actually implemented, but we're good enough.
      */
     outbuf[2] = 5;
-    outbuf[3] = 2; /* Format 2 */
+    outbuf[3] = 2 | 0x10; /* Format 2, HiSup */
 
     if (buflen > 36) {
         outbuf[4] = buflen - 5; /* Additional Length = (Len - 1) - 4 */