Patchwork [27/41] savevm: unexport qemu_fflush

login
register
mail settings
Submitter Juan Quintela
Date Sept. 21, 2012, 8:47 a.m.
Message ID <1348217255-22441-28-git-send-email-quintela@redhat.com>
Download mbox | patch
Permalink /patch/185662/
State New
Headers show

Comments

Juan Quintela - Sept. 21, 2012, 8:47 a.m.
It is not used outside of savevm.c

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 qemu-file.h | 1 -
 savevm.c    | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
Paolo Bonzini - Sept. 21, 2012, 12:45 p.m.
Il 21/09/2012 10:47, Juan Quintela ha scritto:
> It is not used outside of savevm.c
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  qemu-file.h | 1 -
>  savevm.c    | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/qemu-file.h b/qemu-file.h
> index 31b83f6..d8487cd 100644
> --- a/qemu-file.h
> +++ b/qemu-file.h
> @@ -71,7 +71,6 @@ QEMUFile *qemu_fopen_socket(int fd);
>  QEMUFile *qemu_popen(FILE *popen_file, const char *mode);
>  QEMUFile *qemu_popen_cmd(const char *command, const char *mode);
>  int qemu_stdio_fd(QEMUFile *f);
> -void qemu_fflush(QEMUFile *f);
>  int qemu_fclose(QEMUFile *f);
>  void qemu_put_buffer(QEMUFile *f, const uint8_t *buf, int size);
>  void qemu_put_byte(QEMUFile *f, int v);
> diff --git a/savevm.c b/savevm.c
> index c7fe283..1ec6ff1 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -461,7 +461,7 @@ static void qemu_file_set_if_error(QEMUFile *f, int ret)
>   *
>   * In case of error, last_error is set.
>   */
> -void qemu_fflush(QEMUFile *f)
> +static void qemu_fflush(QEMUFile *f)
>  {
>      if (!f->put_buffer)
>          return;
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Patch

diff --git a/qemu-file.h b/qemu-file.h
index 31b83f6..d8487cd 100644
--- a/qemu-file.h
+++ b/qemu-file.h
@@ -71,7 +71,6 @@  QEMUFile *qemu_fopen_socket(int fd);
 QEMUFile *qemu_popen(FILE *popen_file, const char *mode);
 QEMUFile *qemu_popen_cmd(const char *command, const char *mode);
 int qemu_stdio_fd(QEMUFile *f);
-void qemu_fflush(QEMUFile *f);
 int qemu_fclose(QEMUFile *f);
 void qemu_put_buffer(QEMUFile *f, const uint8_t *buf, int size);
 void qemu_put_byte(QEMUFile *f, int v);
diff --git a/savevm.c b/savevm.c
index c7fe283..1ec6ff1 100644
--- a/savevm.c
+++ b/savevm.c
@@ -461,7 +461,7 @@  static void qemu_file_set_if_error(QEMUFile *f, int ret)
  *
  * In case of error, last_error is set.
  */
-void qemu_fflush(QEMUFile *f)
+static void qemu_fflush(QEMUFile *f)
 {
     if (!f->put_buffer)
         return;