Patchwork [33/41] savevm: make qemu_fill_buffer() be consistent

login
register
mail settings
Submitter Juan Quintela
Date Sept. 21, 2012, 8:47 a.m.
Message ID <1348217255-22441-34-git-send-email-quintela@redhat.com>
Download mbox | patch
Permalink /patch/185636/
State New
Headers show

Comments

Juan Quintela - Sept. 21, 2012, 8:47 a.m.
It was setting last_error directly once, and with the helper the other time.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 savevm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Paolo Bonzini - Sept. 21, 2012, 12:48 p.m.
Il 21/09/2012 10:47, Juan Quintela ha scritto:
> It was setting last_error directly once, and with the helper the other time.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  savevm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/savevm.c b/savevm.c
> index 8ddb9d5..4e4aa3c 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -501,7 +501,7 @@ static void qemu_fill_buffer(QEMUFile *f)
>          f->buf_size += len;
>          f->buf_offset += len;
>      } else if (len == 0) {
> -        f->last_error = -EIO;
> +        qemu_file_set_error(f, -EIO);
>      } else if (len != -EAGAIN)
>          qemu_file_set_error(f, len);
>  }
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Patch

diff --git a/savevm.c b/savevm.c
index 8ddb9d5..4e4aa3c 100644
--- a/savevm.c
+++ b/savevm.c
@@ -501,7 +501,7 @@  static void qemu_fill_buffer(QEMUFile *f)
         f->buf_size += len;
         f->buf_offset += len;
     } else if (len == 0) {
-        f->last_error = -EIO;
+        qemu_file_set_error(f, -EIO);
     } else if (len != -EAGAIN)
         qemu_file_set_error(f, len);
 }