Patchwork [v2,5/5] ARM: tegra: enable brcmfmac in defconfig

login
register
mail settings
Submitter lightning314
Date Sept. 21, 2012, 8:55 a.m.
Message ID <1348217700-12309-6-git-send-email-wni@nvidia.com>
Download mbox | patch
Permalink /patch/185626/
State Accepted, archived
Headers show

Comments

lightning314 - Sept. 21, 2012, 8:55 a.m.
New options enabled:
* CFG80211_WEXT: (dependency)
* BRCMFMAC: wlan driver, enable as module.

Signed-off-by: Wei Ni <wni@nvidia.com>
---
 arch/arm/configs/tegra_defconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Arend van Spriel - Sept. 21, 2012, 2:39 p.m.
On 09/21/2012 10:55 AM, Wei Ni wrote:
> New options enabled:
> * CFG80211_WEXT: (dependency)
> * BRCMFMAC: wlan driver, enable as module.
>
> Signed-off-by: Wei Ni <wni@nvidia.com>
> ---
>   arch/arm/configs/tegra_defconfig |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig
> index adcf3c2..04b18ea 100644
> --- a/arch/arm/configs/tegra_defconfig
> +++ b/arch/arm/configs/tegra_defconfig
> @@ -73,6 +73,7 @@ CONFIG_BT_BNEP=y
>   CONFIG_BT_HIDP=y
>   CONFIG_BT_HCIBTUSB=m
>   CONFIG_CFG80211=y
> +CONFIG_CFG80211_WEXT=y

Any particular reason for enabling this? The driver does not 
specifically need it. The option only allows use of WEXT dependent 
user-space tools like iwconfig and iwlist. At least it is not needed by 
brcmfmac driver hence it does not select it.

You indicate there is a dependency. Could you elaborate?

Gr. AvS


--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stephen Warren - Sept. 21, 2012, 4:19 p.m.
On 09/21/2012 08:39 AM, Arend van Spriel wrote:
> On 09/21/2012 10:55 AM, Wei Ni wrote:
>> New options enabled:
>> * CFG80211_WEXT: (dependency)
>> * BRCMFMAC: wlan driver, enable as module.
>>
>> Signed-off-by: Wei Ni <wni@nvidia.com>
>> ---
>>   arch/arm/configs/tegra_defconfig |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/configs/tegra_defconfig
>> b/arch/arm/configs/tegra_defconfig
>> index adcf3c2..04b18ea 100644
>> --- a/arch/arm/configs/tegra_defconfig
>> +++ b/arch/arm/configs/tegra_defconfig
>> @@ -73,6 +73,7 @@ CONFIG_BT_BNEP=y
>>   CONFIG_BT_HIDP=y
>>   CONFIG_BT_HCIBTUSB=m
>>   CONFIG_CFG80211=y
>> +CONFIG_CFG80211_WEXT=y
> 
> Any particular reason for enabling this? The driver does not
> specifically need it. The option only allows use of WEXT dependent
> user-space tools like iwconfig and iwlist. At least it is not needed by
> brcmfmac driver hence it does not select it.
> 
> You indicate there is a dependency. Could you elaborate?

"Dependency" probably isn't correct.

However, the intent of tegra_defconfig is to provide a useful
configuration for Tegra boards. Without the ability to use
iwconfig/iwlist, enabling the wireless driver doesn't seem useful; how
would someone configure the wireless connection?
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Arend van Spriel - Sept. 21, 2012, 7:05 p.m.
On 09/21/2012 06:19 PM, Stephen Warren wrote:
> On 09/21/2012 08:39 AM, Arend van Spriel wrote:
>> On 09/21/2012 10:55 AM, Wei Ni wrote:
>>> New options enabled:
>>> * CFG80211_WEXT: (dependency)
>>> * BRCMFMAC: wlan driver, enable as module.
>>>
>>> Signed-off-by: Wei Ni <wni@nvidia.com>
>>> ---
>>>    arch/arm/configs/tegra_defconfig |    2 ++
>>>    1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/configs/tegra_defconfig
>>> b/arch/arm/configs/tegra_defconfig
>>> index adcf3c2..04b18ea 100644
>>> --- a/arch/arm/configs/tegra_defconfig
>>> +++ b/arch/arm/configs/tegra_defconfig
>>> @@ -73,6 +73,7 @@ CONFIG_BT_BNEP=y
>>>    CONFIG_BT_HIDP=y
>>>    CONFIG_BT_HCIBTUSB=m
>>>    CONFIG_CFG80211=y
>>> +CONFIG_CFG80211_WEXT=y
>>
>> Any particular reason for enabling this? The driver does not
>> specifically need it. The option only allows use of WEXT dependent
>> user-space tools like iwconfig and iwlist. At least it is not needed by
>> brcmfmac driver hence it does not select it.
>>
>> You indicate there is a dependency. Could you elaborate?
>
> "Dependency" probably isn't correct.
>
> However, the intent of tegra_defconfig is to provide a useful
> configuration for Tegra boards. Without the ability to use
> iwconfig/iwlist, enabling the wireless driver doesn't seem useful; how
> would someone configure the wireless connection?

Let me explain. CFG80211 provides a netlink api called NL80211 which is 
favorable over WEXT api. In user-space the iw tool is replacing iwconfig 
and iwlist. Also wpa_supplicant has support for both wext and nl80211.

CFG80211_WEXT basically provides an adaptation/compatibility layer that 
allows user-space tools to interact with cfg80211 drivers. However, it 
is intended to be phased out so I would not recommend putting it in a 
defconfig.

Gr. AvS


--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stephen Warren - Sept. 24, 2012, 5:48 p.m.
On 09/21/2012 01:05 PM, Arend van Spriel wrote:
> On 09/21/2012 06:19 PM, Stephen Warren wrote:
>> On 09/21/2012 08:39 AM, Arend van Spriel wrote:
>>> On 09/21/2012 10:55 AM, Wei Ni wrote:
>>>> New options enabled:
>>>> * CFG80211_WEXT: (dependency)
>>>> * BRCMFMAC: wlan driver, enable as module.
>>>>
>>>> Signed-off-by: Wei Ni <wni@nvidia.com>
>>>> ---
>>>>    arch/arm/configs/tegra_defconfig |    2 ++
>>>>    1 files changed, 2 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/arch/arm/configs/tegra_defconfig
>>>> b/arch/arm/configs/tegra_defconfig
>>>> index adcf3c2..04b18ea 100644
>>>> --- a/arch/arm/configs/tegra_defconfig
>>>> +++ b/arch/arm/configs/tegra_defconfig
>>>> @@ -73,6 +73,7 @@ CONFIG_BT_BNEP=y
>>>>    CONFIG_BT_HIDP=y
>>>>    CONFIG_BT_HCIBTUSB=m
>>>>    CONFIG_CFG80211=y
>>>> +CONFIG_CFG80211_WEXT=y
>>>
>>> Any particular reason for enabling this? The driver does not
>>> specifically need it. The option only allows use of WEXT dependent
>>> user-space tools like iwconfig and iwlist. At least it is not needed by
>>> brcmfmac driver hence it does not select it.
>>>
>>> You indicate there is a dependency. Could you elaborate?
>>
>> "Dependency" probably isn't correct.
>>
>> However, the intent of tegra_defconfig is to provide a useful
>> configuration for Tegra boards. Without the ability to use
>> iwconfig/iwlist, enabling the wireless driver doesn't seem useful; how
>> would someone configure the wireless connection?
> 
> Let me explain. CFG80211 provides a netlink api called NL80211 which is
> favorable over WEXT api. In user-space the iw tool is replacing iwconfig
> and iwlist. Also wpa_supplicant has support for both wext and nl80211.
> 
> CFG80211_WEXT basically provides an adaptation/compatibility layer that
> allows user-space tools to interact with cfg80211 drivers. However, it
> is intended to be phased out so I would not recommend putting it in a
> defconfig.

OK, I suppose that I'd expect to use a given kernel's defconfig with a
fairly recent distro, so switching to "iw" is reasonable, and so
removing that defconfig entry is reasonable. I'll just remove that line
when applying these patches unless there's any other need for a re-spin.

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig
index adcf3c2..04b18ea 100644
--- a/arch/arm/configs/tegra_defconfig
+++ b/arch/arm/configs/tegra_defconfig
@@ -73,6 +73,7 @@  CONFIG_BT_BNEP=y
 CONFIG_BT_HIDP=y
 CONFIG_BT_HCIBTUSB=m
 CONFIG_CFG80211=y
+CONFIG_CFG80211_WEXT=y
 CONFIG_MAC80211=y
 CONFIG_RFKILL=y
 CONFIG_RFKILL_INPUT=y
@@ -98,6 +99,7 @@  CONFIG_USB_PEGASUS=y
 CONFIG_USB_USBNET=y
 CONFIG_USB_NET_SMSC75XX=y
 CONFIG_USB_NET_SMSC95XX=y
+CONFIG_BRCMFMAC=m
 CONFIG_RT2X00=y
 CONFIG_RT2800USB=m
 CONFIG_INPUT_EVDEV=y