Patchwork [v3,2/2] ccid: new package

login
register
mail settings
Submitter Waldemar Rymarkiewicz
Date Sept. 21, 2012, 7:32 a.m.
Message ID <1348212739-32093-2-git-send-email-waldemar.rymarkiewicz@tieto.com>
Download mbox | patch
Permalink /patch/185600/
State Superseded
Headers show

Comments

Waldemar Rymarkiewicz - Sept. 21, 2012, 7:32 a.m.
PC/SC driver for USB CCID smart card readers.

http://pcsclite.alioth.debian.org/ccid.html

Signed-off-by: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>
---
 package/Config.in      |    1 +
 package/ccid/Config.in |   12 ++++++++++++
 package/ccid/ccid.mk   |   12 ++++++++++++
 3 files changed, 25 insertions(+)
 create mode 100644 package/ccid/Config.in
 create mode 100644 package/ccid/ccid.mk
Waldemar Rymarkiewicz - Sept. 24, 2012, 11:56 a.m.
>PC/SC driver for USB CCID smart card readers.
>
>http://pcsclite.alioth.debian.org/ccid.html
>
>Signed-off-by: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>
>---
> package/Config.in      |    1 +
> package/ccid/Config.in |   12 ++++++++++++
> package/ccid/ccid.mk   |   12 ++++++++++++
> 3 files changed, 25 insertions(+)
> create mode 100644 package/ccid/Config.in
> create mode 100644 package/ccid/ccid.mk


No more comments on this series?

Thanks,
/Waldek
Waldemar Rymarkiewicz - Sept. 26, 2012, 8 a.m.
Hi,

As I don't see more comments on patches (ccid and pcsc) I sent some time ago would appreciate to get a clear answer if you consider to upstream them or not.

Thanks,
/Waldek
Peter Korsgaard - Sept. 26, 2012, 8:03 a.m.
>>>>>   <Waldemar.Rymarkiewicz@tieto.com> writes:

 > Hi,

 > As I don't see more comments on patches (ccid and pcsc) I sent some
 > time ago would appreciate to get a clear answer if you consider to
 > upstream them or not.

Sorry for the delay. I'll try to find time to review them this week.
Waldemar Rymarkiewicz - Sept. 26, 2012, 8:06 a.m.
Hi Peter.

>Sorry for the delay. I'll try to find time to review them this week.
>

No worries. Just wasn't sure if anyone plan to do more with them or not. 

Then, I will wait for your feedback.

Thanks,
/Waldek
Arnout Vandecappelle - Sept. 30, 2012, 3:11 p.m.
On 21/09/12 09:32, Waldemar Rymarkiewicz wrote:
> PC/SC driver for USB CCID smart card readers.
>
> http://pcsclite.alioth.debian.org/ccid.html
>
> Signed-off-by: Waldemar Rymarkiewicz<waldemar.rymarkiewicz@tieto.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

[snip]
> diff --git a/package/ccid/ccid.mk b/package/ccid/ccid.mk
> new file mode 100644
> index 0000000..d24f75d
> --- /dev/null
> +++ b/package/ccid/ccid.mk
> @@ -0,0 +1,12 @@
> +##########################################################
> +#
> +# CCID
> +#
> +# ########################################################
> +CCID_VERSION = 1.4.7
> +CCID_SOURCE = ccid-$(CCID_VERSION).tar.bz2
> +CCID_SITE = https://alioth.debian.org/frs/download.php/3730
> +CCID_INSTALL_STAGING = YES
> +CCID_DEPENDENCIES = pcsc-lite host-pkg-config libusb
> +
> +$(eval $(call autotools-package))

  When installing, ccid says:
copy the src/92_pcscd_ccid.rules file in udev directory (/etc/udev/rules.d/)
Perhaps it would be a good idea to do that?  (If BR2_PACKAGE_UDEV, of course)

  Also, ccid has the same --enable-embedded option as pcsc-lite.  I'm not
sure if it is functional, though.

  Regards,
  Arnout
Waldemar Rymarkiewicz - Oct. 5, 2012, 9:57 a.m.
Hi,

>  When installing, ccid says:
>copy the src/92_pcscd_ccid.rules file in udev directory (/etc/udev/rules.d/)
>Perhaps it would be a good idea to do that?  (If BR2_PACKAGE_UDEV, of course)

or maybe "if BR2_ROTFS_DEVICE_CREATION_DYNAMIC_UDEV" would be better ?
Should  POST_UNINSTALL_TARGET_HOOKS be added as well ?

>  Also, ccid has the same --enable-embedded option as pcsc-lite.  I'm not
>sure if it is functional, though.

I doubt as well. Will leave it as it's.


Thanks,
/Waldek

Patch

diff --git a/package/Config.in b/package/Config.in
index dcc84b6..a0fb593 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -382,6 +382,7 @@  source "package/zxing/Config.in"
 endmenu
 
 menu "Hardware handling"
+source "package/ccid/Config.in"
 source "package/libaio/Config.in"
 source "package/libraw1394/Config.in"
 source "package/tslib/Config.in"
diff --git a/package/ccid/Config.in b/package/ccid/Config.in
new file mode 100644
index 0000000..c9b77d1
--- /dev/null
+++ b/package/ccid/Config.in
@@ -0,0 +1,12 @@ 
+config BR2_PACKAGE_CCID
+	bool "ccid"
+	select BR2_PACKAGE_PCSC_LITE
+	select BR2_PACKAGE_LIBUSB
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
+	help
+	  PC/SC driver for USB CCID smart card readers
+
+	  http://pcsclite.alioth.debian.org/ccid.html
+
+comment "ccid needs a toolchain with thread support"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/ccid/ccid.mk b/package/ccid/ccid.mk
new file mode 100644
index 0000000..d24f75d
--- /dev/null
+++ b/package/ccid/ccid.mk
@@ -0,0 +1,12 @@ 
+##########################################################
+#
+# CCID
+#
+# ########################################################
+CCID_VERSION = 1.4.7
+CCID_SOURCE = ccid-$(CCID_VERSION).tar.bz2
+CCID_SITE = https://alioth.debian.org/frs/download.php/3730
+CCID_INSTALL_STAGING = YES
+CCID_DEPENDENCIES = pcsc-lite host-pkg-config libusb
+
+$(eval $(call autotools-package))